Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50431
Return-Path: <glopes@nebm.ist.utl.pt>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 67911 invoked from network); 23 Nov 2010 10:29:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Nov 2010 10:29:14 -0000
Authentication-Results: pb1.pair.com smtp.mail=glopes@nebm.ist.utl.pt; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=glopes@nebm.ist.utl.pt; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
X-PHP-List-Original-Sender: glopes@nebm.ist.utl.pt
X-Host-Fingerprint: 193.136.128.22 smtp2.ist.utl.pt Linux 2.6
Received: from [193.136.128.22] ([193.136.128.22:33295] helo=smtp2.ist.utl.pt)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 0D/B0-59959-8779BEC4 for <internals@lists.php.net>; Tue, 23 Nov 2010 05:29:13 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp2.ist.utl.pt (Postfix) with ESMTP id 00D3270003E7;
	Tue, 23 Nov 2010 10:29:10 +0000 (WET)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at ist.utl.pt
Received: from smtp2.ist.utl.pt ([127.0.0.1])
	by localhost (smtp2.ist.utl.pt [127.0.0.1]) (amavisd-new, port 10025)
	with LMTP id 7CQDqu7xEThP; Tue, 23 Nov 2010 10:29:09 +0000 (WET)
Received: from mail2.ist.utl.pt (mail.ist.utl.pt [IPv6:2001:690:2100:1::8])
	by smtp2.ist.utl.pt (Postfix) with ESMTP id 6449C70003D3;
	Tue, 23 Nov 2010 10:29:09 +0000 (WET)
Received: from cataphract-old.dulce.lo.geleia.net (cataphract-old.dulce.lo.geleia.net [IPv6:2001:470:94a2:2:9978:6e7:759:40ee])
	(Authenticated sender: ist155741)
	by mail2.ist.utl.pt (Postfix) with ESMTPSA id 9286B2008605;
	Tue, 23 Nov 2010 10:29:06 +0000 (WET)
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: internals@lists.php.net, "Dmitry Stogov" <dmitry@zend.com>
Cc: "Christopher Jones" <christopher.jones@oracle.com>, "Derick Rethans"
 <derick@php.net>, "Kalle Sommer Nielsen" <kalle@php.net>, "Zeev Suraski"
 <zeev@zend.com>, "Andi Gutmans" <andi@zend.com>, "Moriyoshi Koizumi"
 <moriyoshi@php.net>
References: <4CE537B0.1030607@zend.com> <4CE56978.9050102@oracle.com>
 <alpine.DEB.2.00.1011182003430.26633@kossu.derickrethans.nl>
 <4CE686BC.4080307@zend.com> <4CEAECC2.6060403@oracle.com>
 <4CEB8AB9.4070909@zend.com>
Date: Tue, 23 Nov 2010 10:28:58 -0000
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?iso-8859-15?Q?N=FAcleo_de_Eng=2E_Biom=E9dica_?=
 =?iso-8859-15?Q?do_IST?=
Message-ID: <op.vmmcqkqlidpuyk@cataphract-old.dulce.lo.geleia.net>
In-Reply-To: <4CEB8AB9.4070909@zend.com>
User-Agent: Opera Mail/10.63 (Win32)
Subject: Re: [PHP-DEV] --enable-zend-multibyte
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Tue, 23 Nov 2010 09:34:49 -0000, Dmitry Stogov <dmitry@zend.com> wrote:

> hi,
>
> I've prepared the patch which completely removes compile-time
> --enable-zend-multibyte configuration directive.
>
> The configuration can be changed at run-tume using zend.multibyte=0/1.
>
> The patch also fixes Unicode detection for phar archives.
>
> I would like to commit it on Thursday.
>

Just two comments:

* You have a line commented out with // (line #443)
* The phar fix autodetection is wrong. You look for __HALT_COMPILER, but  
you should be looking for __HALT_COMPILER();, __halt_compiler(); or any  
casing variation. __HALT_COMPILER, by itself, does nothing (see  
http://lxr.php.net/opengrok/xref/PHP_TRUNK/Zend/zend_language_parser.y#219  
). See the patches in #53199.

Also remember to close #42396 once you commit a proper fix.

Other than that, no objections.

-- 
Gustavo Lopes