Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50413 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72997 invoked from network); 22 Nov 2010 22:21:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Nov 2010 22:21:41 -0000 Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.121 cause and error) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 148.87.113.121 rcsinet10.oracle.com Linux 2.6 Received: from [148.87.113.121] ([148.87.113.121:61470] helo=rcsinet10.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/B2-59959-4FCEAEC4 for ; Mon, 22 Nov 2010 17:21:41 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oAMMLZ6W018184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Nov 2010 22:21:37 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oAM9xYnc014032; Mon, 22 Nov 2010 22:21:28 GMT Received: from abhmt019.oracle.com by acsmt355.oracle.com with ESMTP id 803048141290464451; Mon, 22 Nov 2010 14:20:51 -0800 Received: from [130.35.68.31] (/130.35.68.31) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Nov 2010 14:20:51 -0800 Message-ID: <4CEAECC2.6060403@oracle.com> Date: Mon, 22 Nov 2010 14:20:50 -0800 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Dmitry Stogov CC: Derick Rethans , internals@lists.php.net, Kalle Sommer Nielsen References: <4CE537B0.1030607@zend.com> <4CE56978.9050102@oracle.com> <4CE686BC.4080307@zend.com> In-Reply-To: <4CE686BC.4080307@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] --enable-zend-multibyte From: christopher.jones@oracle.com (Christopher Jones) On 11/19/2010 06:16 AM, Dmitry Stogov wrote: > > > Derick Rethans wrote: >> On Thu, 18 Nov 2010, Christopher Jones wrote: >> >>> On 11/18/2010 06:26 AM, Dmitry Stogov wrote: >>>> The proposed patch allows compiling PHP with --enable-zend-multibyte >>>> and then enable or disable multibyte support at run-time using >>>> zend.multibyte=0/1 in php.ini. As result the single binary will be >>>> able to support multibyte encodings and run without zend-multibyte >>>> overhead dependent on configuration. >>>> >>>> The patch doesn't affect PHP compiled without --enable-zend-multibyte. >>>> >>>> I'm going to commit it into trunk before alpha. >>>> Any objections? >>> If the overhead of zend.multibyte=0 is negligable, then why not remove >>> remove the configure option altogether? This would reduce the >>> complexity of the implementation and simplify building & maintenance. >>> Why have two interdependent ways to get the same outcome if one way >>> will do? >> >> Because it has a dependency on mbstring. > > Actually, it doesn't have compile-time dependencies, so it's probably make sense to remove --enable-zend-multibyte completely. > > Thanks. Dmitry. > >> Derick >> Another ease-of-use simplification prior to releasing 5.3.4 is to roll back the addition of ZEND_MULTIBYTE http://svn.php.net/viewvc?view=revision&revision=305266 In future an ini_get() for zend.multibyte would be the solution for http://bugs.php.net/bug.php?id=52348 Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/