Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50398
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=XdCHa0hmrUaxAuo45w1cPNTwZVxl+8ALKrjYYaeTHs1ayP0ZXOgMtM6OQjZH1/SVpy
         83Tuxf6ypUQanACbnieVdQQM+DasUUpZRLIeB9Pa+26zXGcyDwrW8A+VjVz7/1+tv4gR
         Leo/IXhRP0364OkwP5/sGdv6+zb1vauUXl6XM=
MIME-Version: 1.0
In-Reply-To: <AANLkTimZ4sn_gUg_k4VdBpOCgf_iawxKedrPeM8KK3Uj@mail.gmail.com>
References: <20101119154301.GB9213@redhat.com> <AANLkTimZ4sn_gUg_k4VdBpOCgf_iawxKedrPeM8KK3Uj@mail.gmail.com>
Date: Fri, 19 Nov 2010 22:14:43 -0200
Message-ID: <AANLkTinuExjzqG0q1tjRYe3-GDHozvn8Vdaj=5KC6_XR@mail.gmail.com>
To: Chris Stockton <chrisstocktonaz@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001636c5ad921ef43d049570eab5
Subject: Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again
From: felipensp@gmail.com (Felipe Pena)

--001636c5ad921ef43d049570eab5
Content-Type: text/plain; charset=UTF-8

Hi Chris,

2010/11/19 Chris Stockton <chrisstocktonaz@gmail.com>

> On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton <jorton@redhat.com> wrote:
> > The check to prevent extract() overwriting $GLOBALS got broken at some
> > point - here's a fix:
>
> I remember http://bugs.php.net/47409 for this some time ago and seeing
> it marked applied. After taking a peak it looks like the patch in the
> bug report was ignored. One more reason why I stopped contributing I
> guess.
>
>
The fix committed to the related bug was just like your patch, except that
you did the right sizeof() - 1.

Then as you see, we need contributions... making patches... testing fixes...
reviewing fixes...

As it's said in the bugsweb... "Help us make PHP better." :)

-- 
Regards,
Felipe Pena

--001636c5ad921ef43d049570eab5--