Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50395
Return-Path: <chrisstocktonaz@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 87077 invoked from network); 19 Nov 2010 21:26:07 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Nov 2010 21:26:07 -0000
Authentication-Results: pb1.pair.com smtp.mail=chrisstocktonaz@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=chrisstocktonaz@gmail.com; sender-id=pass; domainkeys=bad
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: chrisstocktonaz@gmail.com
X-Host-Fingerprint: 209.85.216.42 mail-qw0-f42.google.com  
Received: from [209.85.216.42] ([209.85.216.42:58308] helo=mail-qw0-f42.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 26/D2-63174-B6BE6EC4 for <internals@lists.php.net>; Fri, 19 Nov 2010 16:26:05 -0500
Received: by qwi2 with SMTP id 2so348804qwi.29
        for <internals@lists.php.net>; Fri, 19 Nov 2010 13:25:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=goXnVsokLjqFo1RlcIMm23CyUeEXqB6fkBuhHw5yug0=;
        b=Pigorhgky2CNaX9gHgdSD7FFuqvTBvZukucCDrQju5dBPM2bqy2dRBHZIqDXu7rMGV
         KvI+2L0m/KzuvNNEzNG/C/AIXLarTbWmk97kHVXuLQw4fmpWXNfrcbwBNKrMhS1dHATO
         EgayCImHBRb5S+O318qTAGymsdApt4NZT/VO4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=Nwva9wI/IBx+28G7Mk1wC2muXjjzyi6HFJiLk571lz+uTg15rq9Pk8h38/I5dcwb63
         T0eCRG6MbkMA1H6i6Juo5DhZulwP7GRNpF6zy4TgoAGPrWSWeyZ8oPkSelhLGG9nbqRu
         hji8jHpmWwh7F6RILRMS41R8WjoBtC8SrBs9Y=
MIME-Version: 1.0
Received: by 10.229.80.2 with SMTP id r2mr2175459qck.170.1290201958887; Fri,
 19 Nov 2010 13:25:58 -0800 (PST)
Received: by 10.229.181.206 with HTTP; Fri, 19 Nov 2010 13:25:58 -0800 (PST)
In-Reply-To: <20101119154301.GB9213@redhat.com>
References: <20101119154301.GB9213@redhat.com>
Date: Fri, 19 Nov 2010 14:25:58 -0700
Message-ID: <AANLkTimZ4sn_gUg_k4VdBpOCgf_iawxKedrPeM8KK3Uj@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again
From: chrisstocktonaz@gmail.com (Chris Stockton)

On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton <jorton@redhat.com> wrote:
> The check to prevent extract() overwriting $GLOBALS got broken at some
> point - here's a fix:

I remember http://bugs.php.net/47409 for this some time ago and seeing
it marked applied. After taking a peak it looks like the patch in the
bug report was ignored. One more reason why I stopped contributing I
guess.

-Chris