Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50385 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18366 invoked from network); 19 Nov 2010 14:08:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Nov 2010 14:08:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.185 il-mr1.zend.com Received: from [212.25.124.185] ([212.25.124.185:37756] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E5/D3-25589-DD486EC4 for ; Fri, 19 Nov 2010 09:08:30 -0500 Received: from il-gw1.zend.com (unknown [10.1.1.22]) by il-mr1.zend.com (Postfix) with ESMTP id 196D150462; Fri, 19 Nov 2010 16:02:48 +0200 (IST) Received: from ws.home (10.1.10.11) by il-ex2.zend.net (10.1.1.22) with Microsoft SMTP Server id 14.0.689.0; Fri, 19 Nov 2010 16:08:20 +0200 Message-ID: <4CE684D7.80107@zend.com> Date: Fri, 19 Nov 2010 17:08:23 +0300 User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Patrick ALLAERT CC: PHP Internals , Moriyoshi Koizumi , Andi Gutmans , Zeev Suraski References: <4CE537B0.1030607@zend.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] --enable-zend-multibyte From: dmitry@zend.com (Dmitry Stogov) CG(multibyte) is defined only inside #ifdef ZEND_MULTIBYTE. Thanks. Dmitry. Patrick ALLAERT wrote: > 2010/11/18 Dmitry Stogov : >> Index: ext/mbstring/mbstring.c >> =================================================================== >> --- ext/mbstring/mbstring.c (revision 305494) >> +++ ext/mbstring/mbstring.c (working copy) >> @@ -1132,6 +1132,9 @@ >> { >> int *list, size; >> >> + if (!CG(multibyte)) { >> + return FAILURE; >> + } >> if (php_mb_parse_encoding_list(new_value, new_value_length, &list, >> &size, 1 TSRMLS_CC)) { >> if (MBSTRG(script_encoding_list) != NULL) { >> free(MBSTRG(script_encoding_list)); > > Should this hunk not be inside an #ifdef ZEND_MULTIBYTE ?