Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50374
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain verizon.net designates 206.46.173.11 as permitted sender)
MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset=UTF-8; format=flowed
Message-ID: <4CE5A352.4080208@verizon.net>
Date: Thu, 18 Nov 2010 17:06:10 -0500
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9)
 Gecko/20100423 Thunderbird/3.0.4
To: =?UTF-8?B?IkplYW4tU8OpYmFzdGllbiBILiI=?= <jeanseb@au-fil-du.net>
Cc: internals@lists.php.net
References: <4CD463AB.2090702@verizon.net> <4CD68A13.90904@au-fil-du.net>
 <4CD6B055.6080503@verizon.net> <4CD6BE6B.6050608@verizon.net>
 <4CE59982.7020202@au-fil-du.net>
In-reply-to: <4CE59982.7020202@au-fil-du.net>
Subject: Re: [PHP-DEV] php gettext bindtextdomain behavior
From: greno@verizon.net (Gerry Reno)

I put my comments and some clarifications about the patch into the bug.

-Gerry


On 11/18/2010 04:24 PM, "Jean-Sébastien H." wrote:
> Hi,
>
> Any feedback on this patch ?
>
> http://bugs.php.net/bug.php?id=53251
>
> Regards,
>
> Le 07/11/2010 15:57, Gerry Reno a écrit :
>    
>> On 11/07/2010 08:57 AM, Gerry Reno wrote:
>>      
>>> On 11/07/2010 06:14 AM, "Jean-Sébastien H." wrote:
>>>        
>>>> Le 05/11/2010 21:06, Gerry Reno a écrit :
>>>>          
>>>>> In PHP 5.2.4 (my version) the gettext bindtextdomain function is not
>>>>> returning the existing directory settings when the directory argument
>>>>> is NULL.
>>>>> That is the expected behavior for bindtextdomain with GNU and it works
>>>>> this way elsewhere such as in python.
>>>>>
>>>>> [...]
>>>>>
>>>>> Can PHP gettext bindtextdomain be fixed to correctly return the
>>>>> existing setting when called with a NULL directory argument?
>>>>>
>>>>> I was not sure if this was a bug so I thought I would present the
>>>>> issue on the internal list first.
>>>>>            
>>>> I filled a bug-report with a patch.
>>>>
>>>> But my patch introduce a BC (see my non regression test :
>>>> ext/gettext/tests/gettext_bindtextdomain-nulldir.phpt)
>>>>
>>>> http://bugs.php.net/bug.php?id=53251
>>>>
>>>>          
>>> Thanks for filing the bug.  I reviewed the patch and it does not seem
>>> to do what is necessary.  What it needs to do is to go get the
>>> current setting from the previous bindtextdomain call.  This means
>>> that 'bindtextdomain' needs to store the current setting so that it
>>> can be retrieved later by a call with a NULL directory argument.
>>>
>>>
>>>
>>>        
>> I added some comments and clarifications on the bindtextdomain problem
>> into the bug http://bugs.php.net/bug.php?id=53251
>>
>>      
>