Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50327
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Andi Gutmans <andi@zend.com>, internals <internals@lists.php.net>
In-Reply-To: <1289899754.3447.3.camel@guybrush>
References: <4CE03E41.9030805@lerdorf.com>
	 <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net>
	 <4CE10E8E.3070901@lerdorf.com>  <1289899754.3447.3.camel@guybrush>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 18 Nov 2010 10:59:24 +0100
Message-ID: <1290074364.16819.85.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Tue, 2010-11-16 at 10:29 +0100, Johannes Schlüter wrote:
> On Mon, 2010-11-15 at 02:42 -0800, Rasmus Lerdorf wrote:
> > Ok, I went through all the 5.3 code.  This should fix the null poisoning
> > problems in 5.3 without breaking binary compatibility:
> > 
> > http://progphp.com/nullpatch.txt
> 
> I didn't check it as I'm on vacation traveling right now, but: Does the
> data: wrapper allow \0 in the data? Something like
> fopen("data:text/plain,foo\0bar" "r");

Answering to myself:

php -r 'var_dump(file_get_contents("data:text/plain,foo\0bar"));'
string(3) "foo"

The data: wrapper looses the stuff already. So I see no harm by the
patch. It might even produce an error in this situation which is a good
thing (while everybody should use base64 with data: anyways ...)

johannes