Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=r1xJW9BPb2qiDe4Zr0raa65ae0+XyorJ9J6Rj5FWbUlMmG3CSrcYkXxKr5zQ7Rkwy1
         NM4eMTxdXi/mjuabolECkFNGplmk1pAJrL5HFm45Df6cZwkQCdCQVN/zwowzv6Vya9V3
         rnk4lRWdYn3nDR3lErP4Q6m/AURLb5RZHiZe8=
MIME-Version: 1.0
In-Reply-To: <4CE22181.8090904@lerdorf.com>
References: <4CE03E41.9030805@lerdorf.com>
	<8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net>
	<4CE10E8E.3070901@lerdorf.com>
	<4CE206C0.5070701@sugarcrm.com>
	<8757232E56758B42B2EE4F9D2CA019C908A06A@US-EX2.zend.net>
	<4CE215A3.30606@lerdorf.com>
	<4CE220CB.5090005@sugarcrm.com>
	<4CE22181.8090904@lerdorf.com>
Date: Tue, 16 Nov 2010 12:34:56 +0100
Message-ID: <AANLkTim0fF2O_Q-+AtPZ1vyomxb4-Rri3twUyAbWtxsn@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Andi Gutmans <andi@zend.com>, 
	internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
From: pierre.php@gmail.com (Pierre Joye)

hi,

On Tue, Nov 16, 2010 at 7:15 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> On 11/15/10 10:12 PM, Stas Malyshev wrote:
>> Hi!
>>
>>> Well, it changes the signature of that function, so while we don't brea=
k
>>> backward binary compatibility, we break forward compatibility within th=
e
>>> 5.3 branch. =A0As in, if I change my extension to use this new NoNull
>>> string flag, it will no longer work on<5.3.3 whereas if I do the
>>> if(strlen(filename) !=3D filename_len) check, this will still work in a=
ll
>>> 5.3 releases.
>>
>> So if you have such extension, and you need to have it compatible with
>> previous versions (e.g. PECL one), use the check. That doesn't prevent
>> us from having the flag in the core code and thus keeping it cleaner.
>
> It still worries me a bit. =A0Distros love to separate core extensions
> into separate packages and if you update one of those without updating
> the core package, it will break. =A0Hopefully they have hard dependencies
> so you can't install php-curl-5.3.4 on php-5.3.3, for example.

Same here, it is somehow a API incompatibility. We did similar changes
in the past and forced us to have two versions of extensions (afair it
was <5.2.5 and >=3D5.2.6). That was really painful and took years to get
rid of 5.2.5 support.

I like the idea of having a (maybe not so perfect) solution for 5.3.x
using Rasmus patch and do it right in trunk.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org