Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50244
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=sDYoa6PJ4D4PK0PqnhY8IJPYKIgWUIuegu88ug034yQz9nZPJ332b6OOZjtlRznpJ1
         cH+IbxeNh2FRN1QGgSs+xeltPuMUE9xBj2K7nqXCFvFblqohF4lOMcXyAYCGM59hqNyq
         n+M6iJUYYHYAAJTwOBxGfvkLXWnMuOhBe6t7o=
MIME-Version: 1.0
In-Reply-To: <4CE2118A.7060601@sugarcrm.com>
References: <4CE03E41.9030805@lerdorf.com>
	<8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net>
	<4CE10E8E.3070901@lerdorf.com>
	<4CE206C0.5070701@sugarcrm.com>
	<4CE20C4E.3010709@lerdorf.com>
	<4CE2118A.7060601@sugarcrm.com>
Date: Tue, 16 Nov 2010 12:31:48 +0100
Message-ID: <AANLkTinPqag4Q+_-d=hGGndE_Oq4BDJuRqhfu1Bvs+xC@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
From: pierre.php@gmail.com (Pierre Joye)

On Tue, Nov 16, 2010 at 6:07 AM, Stas Malyshev <smalyshev@sugarcrm.com> wro=
te:
> Hi!
>
>> Yeah, I thought about that too. =A0Still not something we can do without
>> breaking binary compatibility in the 5.3 branch though and I really
>> would like to at least get all the core functions to guard themselves
>> against null-poisoning there.
>
> How adding a new option char to zend_parse_parameters breaks BC?

That's something I like to have as well. For two main reasons:

- avoid painful and repetitive path cleaning (VCWD&co)
- may save some memory ops (alloc, free, dup) while a file will not be
processed many times by each part of the engine
  - exts do a check, then stream and TSRM at the end. That's expensive
and should be removed

A possible solution would be to return a struct with a smart str ptr
for the given path, the resolved path and some custom OS specific data
(like stats info, permissions, etc.). Doing so each information about
a given path will be requested/generated only once.


Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org