Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
Date: Tue, 16 Nov 2010 09:44:06 +0000 (GMT)
To: Rasmus Lerdorf <rasmus@lerdorf.com>
cc: Andi Gutmans <andi@zend.com>, internals <internals@lists.php.net>
In-Reply-To: <4CE10E8E.3070901@lerdorf.com>
Message-ID: <alpine.DEB.2.00.1011160940390.26633@kossu.derickrethans.nl>
References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
From: derick@php.net (Derick Rethans)

On Mon, 15 Nov 2010, Rasmus Lerdorf wrote:

> Ok, I went through all the 5.3 code.  This should fix the null poisoning
> problems in 5.3 without breaking binary compatibility:
> 
> http://progphp.com/nullpatch.txt
> 
> There are quite a few places where we can't solve it centrally, so
> perhaps we need to take the same approach in trunk.

I've had a look at that patch, and it looks a little bit like a kludge.
I'm saying that because it's quite easy to miss a specific case where a 
line like:

+	if (strlen(filename) != filename_len) {
+		RETURN_FALSE;
+	}

should/could be added. I prefer a fix that solves this properly, and 
that requires breaking BC as I understood it. Perhaps we could just take 
care of this in trunk only? Or at last, add a macro for doing the check 
from above?

cheers,
Derick