Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50231 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79938 invoked from network); 16 Nov 2010 06:15:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Nov 2010 06:15:36 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.160.170 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:54008] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AB/0D-25603-78122EC4 for ; Tue, 16 Nov 2010 01:15:36 -0500 Received: by gyg10 with SMTP id 10so147880gyg.29 for ; Mon, 15 Nov 2010 22:15:33 -0800 (PST) Received: by 10.90.2.39 with SMTP id 39mr9011579agb.188.1289888133073; Mon, 15 Nov 2010 22:15:33 -0800 (PST) Received: from Anonymous.local (c-98-234-184-167.hsd1.ca.comcast.net [98.234.184.167]) by mx.google.com with ESMTPS id n49sm556181yha.34.2010.11.15.22.15.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 15 Nov 2010 22:15:32 -0800 (PST) Message-ID: <4CE22181.8090904@lerdorf.com> Date: Mon, 15 Nov 2010 22:15:29 -0800 User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Stas Malyshev CC: Andi Gutmans , internals References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com> <4CE206C0.5070701@sugarcrm.com> <8757232E56758B42B2EE4F9D2CA019C908A06A@US-EX2.zend.net> <4CE215A3.30606@lerdorf.com> <4CE220CB.5090005@sugarcrm.com> In-Reply-To: <4CE220CB.5090005@sugarcrm.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk From: rasmus@lerdorf.com (Rasmus Lerdorf) On 11/15/10 10:12 PM, Stas Malyshev wrote: > Hi! > >> Well, it changes the signature of that function, so while we don't break >> backward binary compatibility, we break forward compatibility within the >> 5.3 branch. As in, if I change my extension to use this new NoNull >> string flag, it will no longer work on<5.3.3 whereas if I do the >> if(strlen(filename) != filename_len) check, this will still work in all >> 5.3 releases. > > So if you have such extension, and you need to have it compatible with > previous versions (e.g. PECL one), use the check. That doesn't prevent > us from having the flag in the core code and thus keeping it cleaner. It still worries me a bit. Distros love to separate core extensions into separate packages and if you update one of those without updating the core package, it will break. Hopefully they have hard dependencies so you can't install php-curl-5.3.4 on php-5.3.3, for example. -Rasmus