Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50230 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78528 invoked from network); 16 Nov 2010 06:12:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Nov 2010 06:12:33 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.173 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.173 smtp173.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.173] ([67.192.241.173:47943] helo=smtp173.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 12/CC-25603-0D022EC4 for ; Tue, 16 Nov 2010 01:12:33 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp17.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id DC2A218822B; Tue, 16 Nov 2010 01:12:29 -0500 (EST) X-Virus-Scanned: OK Received: by smtp17.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 8550218817B; Tue, 16 Nov 2010 01:12:29 -0500 (EST) Message-ID: <4CE220CB.5090005@sugarcrm.com> Date: Mon, 15 Nov 2010 22:12:27 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Rasmus Lerdorf CC: Andi Gutmans , internals References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com> <4CE206C0.5070701@sugarcrm.com> <8757232E56758B42B2EE4F9D2CA019C908A06A@US-EX2.zend.net> <4CE215A3.30606@lerdorf.com> In-Reply-To: <4CE215A3.30606@lerdorf.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Well, it changes the signature of that function, so while we don't break > backward binary compatibility, we break forward compatibility within the > 5.3 branch. As in, if I change my extension to use this new NoNull > string flag, it will no longer work on<5.3.3 whereas if I do the > if(strlen(filename) != filename_len) check, this will still work in all > 5.3 releases. So if you have such extension, and you need to have it compatible with previous versions (e.g. PECL one), use the check. That doesn't prevent us from having the flag in the core code and thus keeping it cleaner. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227