Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5023 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26106 invoked by uid 1010); 26 Oct 2003 23:41:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26022 invoked by uid 1007); 26 Oct 2003 23:41:08 -0000 Message-ID: <20031026234107.26019.qmail@pb1.pair.com> To: internals@lists.php.net References: <20031026165338.18992.qmail@pb1.pair.com> <5.1.0.14.2.20031026213148.03145288@127.0.0.1> Date: Sun, 26 Oct 2003 21:36:00 -0200 Lines: 20 X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Posted-By: 200.196.104.198 Subject: Re: [PHP-DEV] internal hashtables [patch included] From: cunha17@uol.com.br ("Cristiano Duarte") "Andi Gutmans" escreveu na mensagem news:5.1.0.14.2.20031026213148.03145288@127.0.0.1... > This doesn't look right. Shouldn't you make sure that module shutdown frees > the hashtables? You can change the dtor if you need. > I'm sorry but I don't quite understand what made you come up with this > solution. Maybe I'm missing something. Shure I can free the hashtable on module shutdown, but since the hashtable is inside a class definition(class constants), should I unregister the class too ? I just put this code because the current symtable only supports userland defined class constants. What is the good practice in developing PHP extensions ? Free all classes defined within an extension at module shutdown ? Best Regards, Cristiano Duarte