Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50229 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75275 invoked from network); 16 Nov 2010 05:51:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Nov 2010 05:51:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Received: from [63.205.162.117] ([63.205.162.117:52723] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2D/4C-25603-8FB12EC4 for ; Tue, 16 Nov 2010 00:51:53 -0500 Received: from us-gw1.zend.com (unknown [192.168.16.15]) by us-mr1.zend.com (Postfix) with ESMTP id 4181C2DEE2; Mon, 15 Nov 2010 22:37:52 -0800 (PST) Received: from US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7]) by US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7%11]) with mapi; Mon, 15 Nov 2010 21:51:49 -0800 To: Rasmus Lerdorf CC: Stas Malyshev , internals Thread-Topic: [PHP-DEV] Adding path_len to all stream functions in trunk Thread-Index: AQHLhDXjOyjbqVLfc0qbZCIBwAwSMZNyBLVwgADcjACAASffAP//iMeQgACI+ID//4Bg4A== Date: Tue, 16 Nov 2010 05:51:55 +0000 Message-ID: <8757232E56758B42B2EE4F9D2CA019C908A256@US-EX2.zend.net> References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com> <4CE206C0.5070701@sugarcrm.com> <8757232E56758B42B2EE4F9D2CA019C908A06A@US-EX2.zend.net> <4CE215A3.30606@lerdorf.com> In-Reply-To: <4CE215A3.30606@lerdorf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Adding path_len to all stream functions in trunk From: andi@zend.com (Andi Gutmans) > -----Original Message----- > From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com] > Sent: Monday, November 15, 2010 9:25 PM > To: Andi Gutmans > Cc: Stas Malyshev; internals > Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk >=20 > Well, it changes the signature of that function, so while we don't break > backward binary compatibility, we break forward compatibility within the > 5.3 branch. As in, if I change my extension to use this new NoNull strin= g flag, it > will no longer work on <5.3.3 whereas if I do the > if(strlen(filename) !=3D filename_len) check, this will still work in all > 5.3 releases. Yes that's correct although I am not sure of chances people would bump into= this issue. In any case, I think it's also fine to fix it the way you suggest in 5.3.x = and then do it via API in the next minor/major version. Andi