Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50227 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70051 invoked from network); 16 Nov 2010 05:16:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Nov 2010 05:16:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Received: from [63.205.162.117] ([63.205.162.117:37909] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A2/7B-25603-3A312EC4 for ; Tue, 16 Nov 2010 00:16:19 -0500 Received: from us-gw1.zend.com (unknown [192.168.16.15]) by us-mr1.zend.com (Postfix) with ESMTP id E4FE02DEE2; Mon, 15 Nov 2010 22:02:18 -0800 (PST) Received: from US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7]) by US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7%11]) with mapi; Mon, 15 Nov 2010 21:16:16 -0800 To: Stas Malyshev , Rasmus Lerdorf CC: internals Thread-Topic: [PHP-DEV] Adding path_len to all stream functions in trunk Thread-Index: AQHLhDXjOyjbqVLfc0qbZCIBwAwSMZNyBLVwgADcjACAASffAP//iMeQ Date: Tue, 16 Nov 2010 05:16:16 +0000 Message-ID: <8757232E56758B42B2EE4F9D2CA019C908A06A@US-EX2.zend.net> References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com> <4CE206C0.5070701@sugarcrm.com> In-Reply-To: <4CE206C0.5070701@sugarcrm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Adding path_len to all stream functions in trunk From: andi@zend.com (Andi Gutmans) > -----Original Message----- > From: Stas Malyshev [mailto:smalyshev@sugarcrm.com] > Sent: Monday, November 15, 2010 8:21 PM > To: Rasmus Lerdorf > Cc: internals > Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk >=20 > Hi! >=20 > > Ok, I went through all the 5.3 code. This should fix the null > > poisoning problems in 5.3 without breaking binary compatibility: > > > > http://progphp.com/nullpatch.txt >=20 > Looking at this patch, I wonder if it wouldn't be cleaner to add new type= (string > without nulls) in parameter parsing and have it handled by parameter pars= ing > in one place instead of doing it in dozens of different places? There mig= ht be > some other places not covered but it would cover most functions - and it'= s > easier to catch/fix those in extensions. That's a nice idea and it also wouldn't break binary compatibility. Andi