Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50225 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64345 invoked from network); 16 Nov 2010 04:45:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Nov 2010 04:45:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.210.42 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.210.42 mail-pz0-f42.google.com Received: from [209.85.210.42] ([209.85.210.42:58934] helo=mail-pz0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/AA-25603-35C02EC4 for ; Mon, 15 Nov 2010 23:45:08 -0500 Received: by pzk27 with SMTP id 27so42902pzk.29 for ; Mon, 15 Nov 2010 20:45:05 -0800 (PST) Received: by 10.142.239.14 with SMTP id m14mr5864534wfh.131.1289882705097; Mon, 15 Nov 2010 20:45:05 -0800 (PST) Received: from Anonymous.local (c-98-234-184-167.hsd1.ca.comcast.net [98.234.184.167]) by mx.google.com with ESMTPS id v19sm865785wfh.0.2010.11.15.20.45.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 15 Nov 2010 20:45:04 -0800 (PST) Message-ID: <4CE20C4E.3010709@lerdorf.com> Date: Mon, 15 Nov 2010 20:45:02 -0800 User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Stas Malyshev CC: internals References: <4CE03E41.9030805@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> <4CE10E8E.3070901@lerdorf.com> <4CE206C0.5070701@sugarcrm.com> In-Reply-To: <4CE206C0.5070701@sugarcrm.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk From: rasmus@lerdorf.com (Rasmus Lerdorf) On 11/15/10 8:21 PM, Stas Malyshev wrote: > Hi! > >> Ok, I went through all the 5.3 code. This should fix the null poisoning >> problems in 5.3 without breaking binary compatibility: >> >> http://progphp.com/nullpatch.txt > > Looking at this patch, I wonder if it wouldn't be cleaner to add new > type (string without nulls) in parameter parsing and have it handled by > parameter parsing in one place instead of doing it in dozens of > different places? There might be some other places not covered but it > would cover most functions - and it's easier to catch/fix those in > extensions. Yeah, I thought about that too. Still not something we can do without breaking binary compatibility in the 5.3 branch though and I really would like to at least get all the core functions to guard themselves against null-poisoning there. -Rasmus