Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50199 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51534 invoked from network); 15 Nov 2010 05:35:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Nov 2010 05:35:50 -0000 Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Received: from [63.205.162.117] ([63.205.162.117:50757] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/DA-43700-4B6C0EC4 for ; Mon, 15 Nov 2010 00:35:49 -0500 Received: from us-gw1.zend.com (unknown [192.168.16.15]) by us-mr1.zend.com (Postfix) with ESMTP id B13B02DE23; Sun, 14 Nov 2010 22:21:34 -0800 (PST) Received: from US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7]) by US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7%11]) with mapi; Sun, 14 Nov 2010 21:35:45 -0800 To: Rasmus Lerdorf CC: internals Thread-Topic: [PHP-DEV] Adding path_len to all stream functions in trunk Thread-Index: AQHLhDXjOyjbqVLfc0qbZCIBwAwSMZNyBLVw Date: Mon, 15 Nov 2010 05:35:54 +0000 Message-ID: <8757232E56758B42B2EE4F9D2CA019C9086B69@US-EX2.zend.net> References: <4CE03E41.9030805@lerdorf.com> In-Reply-To: <4CE03E41.9030805@lerdorf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Adding path_len to all stream functions in trunk From: andi@zend.com (Andi Gutmans) Hi Rasmus, Hope I understood the problem correctly. If not, this answer won't make sen= se :) I do not see a major problem in passing path_len but wonder how much it'd a= ctually solve as we end up calling OS APIs that do not accept path_len, no?= I assume we don't want to start searching all these strings for invalid ch= ars before we pass them to the OS. Andi > -----Original Message----- > From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com] > Sent: Sunday, November 14, 2010 11:54 AM > To: internals > Subject: [PHP-DEV] Adding path_len to all stream functions in trunk >=20 > I think we need to pass along the string length to all the stream functio= ns to > maintain binary string safety through this code. This would fix annoying > problems like http://bugs.php.net/39863 and a bunch of similar issues. > Obviously not something we can do in 5.3 without breaking binary compatib= ility > though. Although we might be able to do something if we assume only char= s > valid in the current charset is valid in file paths. >=20 > Anybody have any other thoughts on this one? >=20 > -Rasmus >=20 > -- > PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visi= t: > http://www.php.net/unsub.php