Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50183 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10249 invoked from network); 13 Nov 2010 19:50:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Nov 2010 19:50:53 -0000 Authentication-Results: pb1.pair.com header.from=ssufficool@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=ssufficool@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: ssufficool@gmail.com X-Host-Fingerprint: 209.85.214.170 mail-iw0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:47318] helo=mail-iw0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4C/81-12820-A1CEEDC4 for ; Sat, 13 Nov 2010 14:50:51 -0500 Received: by iwn6 with SMTP id 6so5388736iwn.29 for ; Sat, 13 Nov 2010 11:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=G3OKTAnfAh+frW0Sk+S+SKIOex1oZuLwkbFkBo5VZiw=; b=FvLXFHlsLWuJS3/4HeGmpFFofs2wBaIBIrUVBstafmO1u/LNOZadLp+lmWx1Bx9gWQ zTwneQ2sfKk478HbkeR1V7ng7UKYm5iEMU9Deml/ysaM/yHAzTzOKEGGjFkjVSiToCDn vgK+6Jh+9jeq0aWNiuBYRYdy84vXoeSSGKHhs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=PbOR8ymytJnMxJDrrgY9U2AoMVqMHh4zs0e5UDp+Op4VFeJvdt+r27hMqdRpuIsaID WePB9wyEXc5DIFc3x6NR338xFFJztMZGrDvQIjzN5di8dv9W8dn3ybWwV/vE8Xx2voWJ sVq0hDvdHoVBb7Eyd0q6tDAjCTR3cYmplsXAE= MIME-Version: 1.0 Received: by 10.42.24.7 with SMTP id u7mr2999414icb.488.1289677847193; Sat, 13 Nov 2010 11:50:47 -0800 (PST) Received: by 10.42.178.65 with HTTP; Sat, 13 Nov 2010 11:50:47 -0800 (PST) In-Reply-To: References: <4CDC469B.7050801@iki.fi> <4CDC8CE7.6050101@iki.fi> <4CDCA56F.1000807@iki.fi> <4CDDC64D.4040405@iki.fi> Date: Sat, 13 Nov 2010 11:50:47 -0800 Message-ID: To: =?ISO-8859-1?B?Suly9G1lIExveWV0?= Cc: Jani Taskinen , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [PHP] multiple sapi (multiple bug reports) From: ssufficool@gmail.com (Stanley Sufficool) 2010/11/13 J=E9r=F4me Loyet : > Le 12 novembre 2010 23:57, Jani Taskinen a =E9crit= : >> I updated the patch: >> >> =A0http://pecl.php.net/~jani/patches/multi-sapi.patch >> >> Now it will fail if no sapi/binary is selected. And "make install" will = now >> also install them all. :) > > it seems to work well. I think Gentoo already has a multiple SAPI build in their PHP patch set. > >> >> The question remains: into what branches can I commit it? >> Some might think it's not a bug fix.. ;) > > I don't really know. As it may changes the way package managers manage > the way to compile multiple sapi at once, it could work for them. It > would maybe be more logic to commit it in trunk. > > In all the cases, I think a patch which changes the unix buildchain > have to be tested widely before commiting. what you think ? > > ++ Jerome >> >> --Jani >> >> >> 12.11.2010 10:23, J=E9r=F4me Loyet kirjoitti: >>> >>> 2010/11/12 Jani Taskinen: >>>> >>>> And here's the patch: >>>> >>>> =A0http://pecl.php.net/~jani/patches/multi-sapi.patch >>>> >>>> Note: It's not quite finished, the 'make install' might not work.. ;) >>> >>> After a very quick try, there is a missing case: if not SAPI and no >>> binaries have been selected, we should trigger an error message. The >>> configture is terminating normaly et make does nothing (normal). >>> >>> ++ Jerome >>> >>>> >>>> --Jani >>>> >>>> >>>> 12.11.2010 2:40, Jani Taskinen kirjoitti: >>>>> >>>>> I'm working on an improvement on how all binaries are build thus >>>>> enabling building all such in one go if one wants to. I already added= a >>>>> check for multiple sapi _modules_ being build, it will error out. >>>>> >>>>> Stay tuned, I'll post the patch once I've tested it a bit. >>>>> >>>>> --Jani >>>>> >>>>> >>>>> 12.11.2010 0:03, J=E9r=F4me Loyet kirjoitti: >>>>>> >>>>>> 2010/11/11 Jani Taskinen: >>>>>>> >>>>>>> 11.11.2010 18:46, Kalle Sommer Nielsen kirjoitti: >>>>>>>> >>>>>>>> Hi J=E9r=F4me >>>>>>>> >>>>>>>> 2010/11/11 J=E9r=F4me Loyet: >>>>>>>>> >>>>>>>>> If this is a normal behaviour, we should add an error at configur= e >>>>>>>>> telling that only one SAPI is supported at once. >>>>>>>>> It not, we should correct it. >>>>>>>>> >>>>>>>>> Did I miss something ? >>>>>>>> >>>>>>>> On Windows we have no problems in compiling multiple SAPI's using = one >>>>>>>> ./configure, so I believe it is indeed a bug on the Unix build sys= tem >>>>>>>> causing this, so yeah I suppose it should be fixed. >>>>>>>> >>>>>>> >>>>>>> Sascha explained this briefly here: >>>>>>> >>>>>>> http://www.mail-archive.com/php-cvs@lists.php.net/msg00413.html >>>>>> >>>>>> I understand it's hard to compile mutiple SAPI (dependancies, linkag= e, >>>>>> ...). In this case, this should be clear at configure and an error >>>>>> message should be shown. It's not reasonable not to be able to compi= le >>>>>> CGI and apache2 sapi without any informations (like >>>>>> http://bugs.php.net/53271). >>>>>> >>>>>> I've made a quick patch (http://pastebin.com/jUGMtSjv) which: >>>>>> >>>>>> - move the sapi/cgi/config9.m4 to config.m4. The reason cgi sapi use= s >>>>>> a config9.m4 file is to be called at configure as the last SAPI. >>>>>> >>>>>> - remove the "No SAPI selected" check in sapi/cgi/config.m4. To me >>>>>> it's not its job. It has to be done by configure. To me, the cgi sap= i >>>>>> must be like any of the others >>>>>> >>>>>> - change the cgi sapi to be disable by default. cgi sapi will be lik= e >>>>>> any other sapi (except cli), disable by default. Basically, PHP is a >>>>>> programming scripting language. The CLI has to be enable by default >>>>>> and other sapi have to be enabled by the user. >>>>>> >>>>>> - add a "No SAPI selected" check in configure.in, after >>>>>> "esyscmd(./build/config-stubs sapi)" (after all sapi config*.m4 file= s >>>>>> have been executed). Use CLI as default SAPI if it's not been >>>>>> disabled. If all SAPI and CLI have been disabled, issue the error >>>>>> message. >>>>>> >>>>>> - A a check in PHP_SELECT_SAPI (in acinclude.m4) to ensure it's been >>>>>> called only once (all SAPI (except CLI) calls this macro). At second >>>>>> call, an error message telling that only one SAPI can be compiled is >>>>>> shown. >>>>>> >>>>>> I don't have a huge php core background but it seems (for me at leas= t) >>>>>> the right way for users. >>>>>> >>>>>> hope it helps. >>>>>> >>>>>>> >>>>>>> Something called ZTS also comes to my mind.. >>>>>> >>>>>> It's not the first time ZTS comes in the discution about multiple >>>>>> SAPI. I've made some tests and looked into the code of the build >>>>>> chain, but I can't see how it's related. Maybe someone can enlight m= e >>>>>> ? >>>>>> >>>>>> thx >>>>>> >>>>>> ++ jerome >>>>> >>>>> >>>> >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>>> >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >