Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50177
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain edigitalresearch.com does not designate 217.154.180.62 as permitted sender)
To: =?windows-1252?Q?"Jani_Taskinen"?= <jani.taskinen@iki.fi>
Cc: =?windows-1252?Q?"J=E9r=F4me_Loyet"?= <jerome@loyet.net>, 
 =?windows-1252?Q?"internals=40lists.php.net"?= <internals@lists.php.net>
Date: Fri, 12 Nov 2010 23:49:54 +0000
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Message-ID: <vmime.4cddd2a2.2a8b.5a09766e233e2fc2@zarafa.edigitalresearch.com>
Subject:  Re: [PHP-DEV] [PHP] multiple sapi (multiple bug reports)
From: james.butler@edigitalresearch.com (=?windows-1252?Q?James_Butler?=)

Just an uninformed thought, trunk=3F This isn't a problem in the runtime, just an installation annoyance for those who compile from source.
Leave the patch for people who want/need it for current versions. I imagine if this has been a major problem for people (and I don't) they will have been compiling binaries separately already.=20


--
James Butler
Sent from my iPhone

On 12 Nov 2010, at 22:58, "Jani Taskinen" <jani.taskinen@iki.fi> wrote:

> I updated the patch:
>=20
>   http://pecl.php.net/~jani/patches/multi-sapi.patch
>=20
> Now it will fail if no sapi/binary is selected. And "make install" will=20
> now also install them all. :)
>=20
> The question remains: into what branches can I commit it=3F
> Some might think it's not a bug fix.. ;)
>=20
> --Jani
>=20
>=20
> 12.11.2010 10:23, J=E9r=F4me Loyet kirjoitti:
>> 2010/11/12 Jani Taskinen<jani.taskinen@iki.fi>:
>>>=20
>>> And here's the patch:
>>>=20
>>>  http://pecl.php.net/~jani/patches/multi-sapi.patch
>>>=20
>>> Note: It's not quite finished, the 'make install' might not work.. ;)
>>=20
>> After a very quick try, there is a missing case: if not SAPI and no
>> binaries have been selected, we should trigger an error message. The
>> configture is terminating normaly et make does nothing (normal).
>>=20
>> ++ Jerome
>>=20
>>>=20
>>> --Jani
>>>=20
>>>=20
>>> 12.11.2010 2:40, Jani Taskinen kirjoitti:
>>>>=20
>>>> I'm working on an improvement on how all binaries are build thus
>>>> enabling building all such in one go if one wants to. I already added a
>>>> check for multiple sapi _modules_ being build, it will error out.
>>>>=20
>>>> Stay tuned, I'll post the patch once I've tested it a bit.
>>>>=20
>>>> --Jani
>>>>=20
>>>>=20
>>>> 12.11.2010 0:03, J=E9r=F4me Loyet kirjoitti:
>>>>>=20
>>>>> 2010/11/11 Jani Taskinen<jani.taskinen@iki.fi>:
>>>>>>=20
>>>>>> 11.11.2010 18:46, Kalle Sommer Nielsen kirjoitti:
>>>>>>>=20
>>>>>>> Hi J=E9r=F4me
>>>>>>>=20
>>>>>>> 2010/11/11 J=E9r=F4me Loyet<jerome@loyet.net>:
>>>>>>>>=20
>>>>>>>> If this is a normal behaviour, we should add an error at configure
>>>>>>>> telling that only one SAPI is supported at once.
>>>>>>>> It not, we should correct it.
>>>>>>>>=20
>>>>>>>> Did I miss something =3F
>>>>>>>=20
>>>>>>> On Windows we have no problems in compiling multiple SAPI's using one
>>>>>>> ./configure, so I believe it is indeed a bug on the Unix build system
>>>>>>> causing this, so yeah I suppose it should be fixed.
>>>>>>>=20
>>>>>>=20
>>>>>> Sascha explained this briefly here:
>>>>>>=20
>>>>>> http://www.mail-archive.com/php-cvs@lists.php.net/msg00413.html
>>>>>=20
>>>>> I understand it's hard to compile mutiple SAPI (dependancies, linkage,
>>>>> ...). In this case, this should be clear at configure and an error
>>>>> message should be shown. It's not reasonable not to be able to compile
>>>>> CGI and apache2 sapi without any informations (like
>>>>> http://bugs.php.net/53271).
>>>>>=20
>>>>> I've made a quick patch (http://pastebin.com/jUGMtSjv) which:
>>>>>=20
>>>>> - move the sapi/cgi/config9.m4 to config.m4. The reason cgi sapi uses
>>>>> a config9.m4 file is to be called at configure as the last SAPI.
>>>>>=20
>>>>> - remove the "No SAPI selected" check in sapi/cgi/config.m4. To me
>>>>> it's not its job. It has to be done by configure. To me, the cgi sapi
>>>>> must be like any of the others
>>>>>=20
>>>>> - change the cgi sapi to be disable by default. cgi sapi will be like
>>>>> any other sapi (except cli), disable by default. Basically, PHP is a
>>>>> programming scripting language. The CLI has to be enable by default
>>>>> and other sapi have to be enabled by the user.
>>>>>=20
>>>>> - add a "No SAPI selected" check in configure.in, after
>>>>> "esyscmd(./build/config-stubs sapi)" (after all sapi config*.m4 files
>>>>> have been executed). Use CLI as default SAPI if it's not been
>>>>> disabled. If all SAPI and CLI have been disabled, issue the error
>>>>> message.
>>>>>=20
>>>>> - A a check in PHP_SELECT_SAPI (in acinclude.m4) to ensure it's been
>>>>> called only once (all SAPI (except CLI) calls this macro). At second
>>>>> call, an error message telling that only one SAPI can be compiled is
>>>>> shown.
>>>>>=20
>>>>> I don't have a huge php core background but it seems (for me at least)
>>>>> the right way for users.
>>>>>=20
>>>>> hope it helps.
>>>>>=20
>>>>>>=20
>>>>>> Something called ZTS also comes to my mind..
>>>>>=20
>>>>> It's not the first time ZTS comes in the discution about multiple
>>>>> SAPI. I've made some tests and looked into the code of the build
>>>>> chain, but I can't see how it's related. Maybe someone can enlight me
>>>>> =3F
>>>>>=20
>>>>> thx
>>>>>=20
>>>>> ++ jerome
>>>>=20
>>>>=20
>>>=20
>>>=20
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>=20
>>>=20
>=20
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20