Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5017 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18524 invoked by uid 1010); 26 Oct 2003 19:34:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 18470 invoked from network); 26 Oct 2003 19:34:46 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 26 Oct 2003 19:34:46 -0000 Received: (qmail 32140 invoked from network); 26 Oct 2003 19:34:43 -0000 Received: from guardian.zend.office (HELO andi-laptop.zend.com) (10.1.1.4) by int.zend.com with SMTP; 26 Oct 2003 19:34:43 -0000 Message-ID: <5.1.0.14.2.20031026213148.03145288@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sun, 26 Oct 2003 21:32:42 +0200 To: "Cristiano Duarte" ,internals@lists.php.net In-Reply-To: <20031026165338.18992.qmail@pb1.pair.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] internal hashtables [patch included] From: andi@zend.com (Andi Gutmans) References: <20031026165338.18992.qmail@pb1.pair.com> At 02:53 PM 10/26/2003 -0200, Cristiano Duarte wrote: >Hi all, > >Just to remind about my problem: >After updating from latest CVS I still had problems with internal >hashtables. I want to make internal class constants and the engine reports >memory leaks. > >So I made this patch wich works for me and removed all memory leaks >regarding hashtables. > >This patch introduces a new macro called ZEND_INIT_INTERNAL_SYMTABLE wich is >to be used instead of ZEND_INIT_SYMTABLE when the hashtables is internal. >That's the only change that should be done in sources that needs internal >hashtables. This doesn't look right. Shouldn't you make sure that module shutdown frees the hashtables? You can change the dtor if you need. I'm sorry but I don't quite understand what made you come up with this solution. Maybe I'm missing something. Andi