Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50119
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain verizon.net designates 206.46.173.19 as permitted sender)
MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset=UTF-8; format=flowed
Message-ID: <4CD6B055.6080503@verizon.net>
Date: Sun, 07 Nov 2010 08:57:41 -0500
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9)
 Gecko/20100423 Thunderbird/3.0.4
To: internals@lists.php.net
References: <4CD463AB.2090702@verizon.net> <4CD68A13.90904@au-fil-du.net>
In-reply-to: <4CD68A13.90904@au-fil-du.net>
Subject: Re: [PHP-DEV] php gettext bindtextdomain behavior
From: greno@verizon.net (Gerry Reno)

On 11/07/2010 06:14 AM, "Jean-Sébastien H." wrote:
> Le 05/11/2010 21:06, Gerry Reno a écrit :
>    
>> In PHP 5.2.4 (my version) the gettext bindtextdomain function is not
>> returning the existing directory settings when the directory argument
>> is NULL.
>> That is the expected behavior for bindtextdomain with GNU and it works
>> this way elsewhere such as in python.
>>
>> [...]
>>
>> Can PHP gettext bindtextdomain be fixed to correctly return the
>> existing setting when called with a NULL directory argument?
>>
>> I was not sure if this was a bug so I thought I would present the
>> issue on the internal list first.
>>      
> I filled a bug-report with a patch.
>
> But my patch introduce a BC (see my non regression test :
> ext/gettext/tests/gettext_bindtextdomain-nulldir.phpt)
>
> http://bugs.php.net/bug.php?id=53251
>
>    

Thanks for filing the bug.  I reviewed the patch and it does not seem to 
do what is necessary.  What it needs to do is to go get the current 
setting from the previous bindtextdomain call.  This means that 
'bindtextdomain' needs to store the current setting so that it can be 
retrieved later by a call with a NULL directory argument.