Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5009
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sun, 26 Oct 2003 14:47:05 +0000
To: =?iso-8859-1?Q?Marcus_B=F6rger?= <helly@php.net>
Cc: Sebastian Bergmann <sebastian@php.net>, internals@lists.php.net
Reply-to: Steph <steph.fox@virgin.net>
Message-ID: <006e01c39bd0$069f1e60$a693e49d@Sfoxstu>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 7BIT
References: <001001c39b7f$a3f37860$a693e49d@Sfoxstu>
 <1111180146218.20031026124309@marcus-boerger.de>
Subject: Re: [PHP-DEV] cracked it!  (cleaning up)
From: steph.fox@virgin.net (Steph)

> This is not correct, both use ptrdiff_t.

Yes.  One already has an include that defines it.. OK OK, agreed that's
tenuous.

> Also you need the sizeof define (which works as a detection define,
too):
> SIZEOF_PTRDIFF_T

This is defined as an absolute in config.w32.h (for 32-bit and 64-bit
architectures).

> Generally your analyse looks good besides the comment above.
> Only i am not sure if we can really nuke the include, you sure about
that?

Definitely cast.c.  Everything builds if you nuke it on snprintf.c too.
If anyone can mail me/point me to a test script that will check
either/both contentions, I have that build sitting here at present..

> However changing the define to the one you suggest might be a good
idea.
>
thx ;)
- Steph