Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50089
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=b12XbgeM2Sn/K2s+LTCZPrp/nbkpiytL5c25oZEM5fI1wDI7+zvDU1aZSwnLpB1HuJ
         O2sKCL/mXyodXjI+YNh3Bk3Ya4+lbNY965bR4kzRHudowC/XubzjmtpPPReJpARJWTCo
         YZKCf7GeJ45b7zSAFbhV8qyHaYxZ8W3utP6UU=
MIME-Version: 1.0
In-Reply-To: <20101024223825.GC19835@gerbil.thgnet.it>
References: <20101024223825.GC19835@gerbil.thgnet.it>
Date: Tue, 2 Nov 2010 23:38:43 -0200
Message-ID: <AANLkTi=qKHRrVFPpjoOq1xafaFzpx69rM0+ekkG-5Gc1@mail.gmail.com>
To: Giovanni Giacobbi <giovanni@giacobbi.net>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0016e6d64b2d3d3d9d04941c1b50
Subject: Re: [PHP-DEV] BC break in 5.3.2 -> 5.3.3 with "parent::" and __call/__callStatic
From: felipensp@gmail.com (Felipe Pena)

--0016e6d64b2d3d3d9d04941c1b50
Content-Type: text/plain; charset=UTF-8

2010/10/24 Giovanni Giacobbi <giovanni@giacobbi.net>

>
> Greetings,
>
> in reference to bug #52713 i'd like to inquire you about this decision
> which actually broke my codebase in different parts.
>
> The situation is this one:
>
> class ActiveRecord {
>
>  public function __call($method, $args) {
>    if ($method == "getFoo") {
>      // implement some default behaviour for getFoo()
>    }
>  }
>
>  public function __callStatic($method, $args) {
>    // do some other stuff
>  }
> }
>
>
> class Bar {
>  // override getFoo() to add some specific behaviour
>  public function getFoo() {
>    // do the specific stuff
>    parent::getFoo();
>  }
> }
>
>
> Until version 5.3.2 this worked fine, starting from version 5.3.3
> parent::getFoo() calls __callStatic() instead of __call().
>
> This is a really bad BC change which i thought you decided to accept only
> in minor versions change and not patch-level versions change.
>
> Anyway, I would even be willing to do some changes to my codebase, but what
> is the solution? I can't see any other way to do this with the obvious
> assumptions that my design is good and that I don't know anything about the
> parent class except there is a getFoo() method implemented somehow.
>
> My wish is that you restore the 5.3.2 behaviour, which sounds very
> reasonable, and maybe introduce another way when you actually want to get
> rid of the context, something like static::
>
>
The change has been reverted in SVN.


Thanks.

-- 
Regards,
Felipe Pena

--0016e6d64b2d3d3d9d04941c1b50--