Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50022 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10791 invoked from network); 30 Oct 2010 16:51:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2010 16:51:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=admin@codeangel.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=admin@codeangel.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain codeangel.org from 216.119.135.130 cause and error) X-PHP-List-Original-Sender: admin@codeangel.org X-Host-Fingerprint: 216.119.135.130 a2s40.a2hosting.com Windows 98 (1) Received: from [216.119.135.130] ([216.119.135.130:37939] helo=a2s40.a2hosting.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5F/47-10139-9FC4CCC4 for ; Sat, 30 Oct 2010 12:51:05 -0400 Received: from c-98-212-133-218.hsd1.il.comcast.net ([98.212.133.218] helo=[192.168.0.100]) by a2s40.a2hosting.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1PCEdx-0000Nl-QU; Sat, 30 Oct 2010 12:51:01 -0400 Message-ID: <4CCC4D07.1020308@codeangel.org> Date: Sat, 30 Oct 2010 11:51:19 -0500 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 MIME-Version: 1.0 To: James Butler CC: "Mike Van Riel" , "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a2s40.a2hosting.com X-AntiAbuse: Original Domain - lists.php.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - codeangel.org Subject: Re: [PHP-DEV] rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON From: admin@codeangel.org (Chad Emrys) On 10/30/2010 11:43 AM, James Butler wrote: > If it ain't broken don't fix it. > > Change for the sake of it is a bad thing. It does things like introduce bugs etc. > > Q1) is it broken? > Q2) if yes exactly what is broken > Q3) does the proposes fix solve the root cause? > > I'm not sure changing the token name is the correct fix to people not knowing what the error means. > > -- > James Butler > Sent from my iPhone > Q1) yes, it is broken, people have to Google or ask around for a very unclear error message when for the most parts errors are (and should be) self explanatory. Q2) Two things are broken: Either the token is named badly, or the token names shouldn't show up in error messages at all and be replaced with something a bit more friendly. Q3) those two fixes above would probably fix that, yes. What is so hard to believe when people see UNEXPECTED T_DOUBLE_COLON on LINE 23 they are gonna look for a double colon on line 23? because they DO.