Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sun, 26 Oct 2003 05:11:39 +0000
To: Sebastian Bergmann <sebastian@php.net>
Cc: internals@lists.php.net
Reply-to: Steph <steph.fox@virgin.net>
Message-ID: <001001c39b7f$a3f37860$a693e49d@Sfoxstu>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 7BIT
Subject: cracked it!  (cleaning up)
From: steph.fox@virgin.net (Steph)

I searched on ssize_t.

There are 5 files where ssize_t is defined:
configure.in //irrelevant to win32
config.w32.h //changed definition to #define ssize_t SSIZE_T because
<windows.h> is more pervasive in the upper reaches of PHP than
<stddef.h>
fcgi_config_win32.h //removed the define, no longer needed
fcgi_config_x86.h //irrelevant to win32
php_mnogo.c //irrelevant to win32

There are 3 files where <stddef.h> is included:
snprintf.c //removed the include line, no longer needed
spprintf.c //needs stddef.h, uses ptrdiff_t
cast.c //removed the include line, no longer needed

There is one file (Sterling's, naturally) where win32 isn't a
consideration:
dio.c //irrelevant to win32

and one file where win32 is irrelevant given the context
(because PHP_PREAD_64 is only defined in acinclude.m4)
php.h //irrelevant to win32

and then there's our friend the gd-breaker:
gd_jpeg.c //removed the ssize_t define, no longer needed

Now we don't HAVE to make those changes, but if we do, it's better
future-proofing for that particular typedef because it provides a more
generic solution than the one currently in place.

G'night!!