Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50013 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97221 invoked from network); 30 Oct 2010 15:56:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2010 15:56:42 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.161.42 mail-fx0-f42.google.com Received: from [209.85.161.42] ([209.85.161.42:42667] helo=mail-fx0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EB/54-10139-8304CCC4 for ; Sat, 30 Oct 2010 11:56:41 -0400 Received: by fxm10 with SMTP id 10so4125862fxm.29 for ; Sat, 30 Oct 2010 08:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:cc:content-type; bh=0hd64Msc1LTOIY1h0xzoEW/m43cFVipIyKu5wvUB5N8=; b=V1so7Wif2VAPUSjlmiTVnkXw5FCWpa3bOEujh+ssFAPJgxPO2gRLiPhr+jDTsdxmAb YvIz/RgG7p49ajiWSEKGuUi0JvoqnpTPYwKSfBBgz3NdiDDPs17jlDHtHx9IKrttCBkh WHJGc5lfUdAfJqR0ebDaBXazCA8dF5Ul3mKAA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=n/DABkgzirTuTjwMCAdjSxhwCawfBK5M4TY+wd3x2F8NghZs4UzIRY13dbp00UXexu vABfHAVNPsULBPyJaxOCwNuvngl1MmOcoukCtnu2zx1vK87w1RGs1Zv/uMgQ7Pzx5XX5 IG9Y7sCq9RuoAOU6ts+blTP//GVZq3j4pVNSg= MIME-Version: 1.0 Received: by 10.223.93.142 with SMTP id v14mr1267849fam.49.1288454196476; Sat, 30 Oct 2010 08:56:36 -0700 (PDT) Received: by 10.223.121.198 with HTTP; Sat, 30 Oct 2010 08:56:36 -0700 (PDT) Date: Sat, 30 Oct 2010 17:56:36 +0200 Message-ID: To: Gustavo Lopes Cc: PHP internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/file.c branches/PHP_5_3/ext/standard/file.h branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.c branches/PHP_5_3/ext/standard/http_fopen_wrapper.c branch From: pierre.php@gmail.com (Pierre Joye) hi, On Sat, Oct 30, 2010 at 3:43 PM, Gustavo Lopes wrote: > The From: header is actually valid in http (see section 14.21 of RFC 2616) and is appropriately used in PHP, as it is. > > Yes, this should arguably be a context option for http/ftp wrappers, though one could argue it's a global setting that happens to reflect on those wrappers. > > In any case, that is a matter outside the realm of bug fixing; I merely made the ini setting that currently exists work correctly. > > Sorry for the top posting. This directive is documented only to be used with FTP. Yes it would be nice to fully support the HTTP RFC, but not by making this implementation more ugly. Also new features should go to trunk. I suggest to actually fix the reported bug and do the right changes and additions in trunk. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org