Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50008
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=NxBVU3snhStWrMIg8uODOzqeSj+YnKWxIf/io5bCjmSoIQ4QojtHA6RZxO4e81lE4z
         apslUz2UmUwq6FN9jtvclxU3ugnU0jUehL+wgcXzkaiB/ROhAVFMw5oiBeC7vVyFKR2I
         NK4NzvwM2/jY7jc3/mFZpt+w3XXv3++GbQNws=
MIME-Version: 1.0
Date: Sat, 30 Oct 2010 13:27:10 +0200
Message-ID: <AANLkTikAF1QvYj7XJmzZm6GF_it+280aWomuiGXFyfZG@mail.gmail.com>
To: =?ISO-8859-1?Q?Gustavo_Andr=E9_dos_Santos_Lopes?= <cataphract@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS
 branches/PHP_5_3/ext/standard/file.c branches/PHP_5_3/ext/standard/file.h
 branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.c branches/PHP_5_3/ext/standard/http_fopen_wrapper.c
 branches/PHP_5_3/ext
From: pierre.php@gmail.com (Pierre Joye)

hi,

Removing the From header for non ftp request sounds good as it is
invalid. However I don't see the need to introduce a global ini
setting. This kind of information are protocol specific and should be
defined either manually in a context (as shown in the report reproduce
code) or as a context option, for a given protocol.

It is also wrong from a design point of view to add protocol options
in this layer (the agent info was a mistake back then already).

I would suggest to apply Richard's patch instead and revert this
change. If we need to add more options to one protocol or another,
then let do it, but in the protocol implementation.

Thanks for your work!

Cheers,

2010/10/29 Gustavo Andr=E9 dos Santos Lopes <cataphract@php.net>:
> cataphract =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Fr=
i, 29 Oct 2010 15:29:15 +0000
>
> Revision: http://svn.php.net/viewvc?view=3Drevision&revision=3D304985
>
> Log:
> - Fixed bug #53198 (changing INI setting "from" with ini_set did not have=
 any
> =A0effect)
> #Made "from" a proper INI setting and bound it to a global variable.
> #Previously, it was simply read from the hash table with the parsed ini f=
ile
> #by using cfg_get_string (I wonder why this mechanism still exists...)
>
> Bug: http://bugs.php.net/53198 (Assigned) "From:" header sent on http req=
uest when using stream_context.
>
> Changed paths:
> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/NEWS
> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/ext/standard/file.c
> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/ext/standard/file.h
> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.=
c
> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/ext/standard/http_fopen_wrapper=
.c
> =A0 =A0A =A0 php/php-src/branches/PHP_5_3/ext/standard/tests/http/bug5319=
8.phpt
> =A0 =A0U =A0 php/php-src/trunk/ext/standard/file.c
> =A0 =A0U =A0 php/php-src/trunk/ext/standard/file.h
> =A0 =A0U =A0 php/php-src/trunk/ext/standard/ftp_fopen_wrapper.c
> =A0 =A0U =A0 php/php-src/trunk/ext/standard/http_fopen_wrapper.c
> =A0 =A0A =A0 php/php-src/trunk/ext/standard/tests/http/bug53198.phpt

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org