Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49966
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain immomigsa.ch from 94.103.100.39 cause and error)
Date: Mon, 25 Oct 2010 01:04:00 +0200
To: internals@lists.php.net
Message-ID: <20101024230400.GC88594@croustillant.local>
References: <20101024223825.GC19835@gerbil.thgnet.it>
 <4CC4B628.3060304@sugarcrm.com>
 <20101024225628.GB88594@croustillant.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101024225628.GB88594@croustillant.local>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PHP-DEV] BC break in 5.3.2 -> 5.3.3 with "parent::" and
 __call/__callStatic
From: colder@php.net (Etienne Kneuss)

On Oct 25  0:56:28, Etienne Kneuss wrote:
> On Oct 24 15:41:44, Stas Malyshev wrote:
> > Hi!
> > 
> > >class Bar {
> > >   // override getFoo() to add some specific behaviour
> > >   public function getFoo() {
> > >     // do the specific stuff
> > >     parent::getFoo();
> > >   }
> > >}
> > 
> > I think you meant Bar to extend ActiveRecord? But anyway, I think
> > that this particular call should be done through __call, not
> > __callStatic, since it's basically non-static call. The line between
> > the two wasn't really well-defined in PHP (you could call static
> > methods non-statically and vice versa) which is a pity but I think
> > distinction can be made in this case.
> 
> Exactly, if Bar::getFoo is not called statically, parent::getFoo() will
> not be a static call, it should not get through __callStatic.
> 
> Best,

Oh, and #51176 seems bogus to me. "::" is not sufficient to indicate a
static call, neither is "self::", "static::", or "Foo::".

A call is only static if one of the two following conditions match:
    1) the target method is declared as static
    2) the call comes from an object-less scope

> 
> > 
> > -- 
> > Stanislav Malyshev, Software Architect
> > SugarCRM: http://www.sugarcrm.com/
> > (408)454-6900 ext. 227
> > 
> > -- 
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> > 
> 
> -- 
> Etienne Kneuss
> http://www.colder.ch
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 

-- 
Etienne Kneuss
http://www.colder.ch