Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49961 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7025 invoked from network); 23 Oct 2010 07:46:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Oct 2010 07:46:38 -0000 Authentication-Results: pb1.pair.com header.from=jorrit@wafel.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jorrit@wafel.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain wafel.org from 212.29.160.232 cause and error) X-PHP-List-Original-Sender: jorrit@wafel.org X-Host-Fingerprint: 212.29.160.232 smtp1.infopact.nl Received: from [212.29.160.232] ([212.29.160.232:48226] helo=mc-smtp1.infopact.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9C/36-04650-BD292CC4 for ; Sat, 23 Oct 2010 03:46:36 -0400 Received: from [192.168.127.100] (wafel.org [82.210.98.66]) by mc-smtp1.infopact.nl (8.14.3/8.14.3) with ESMTP id o9N7kUMj020326; Sat, 23 Oct 2010 09:46:32 +0200 Message-ID: <4CC292D6.6060300@wafel.org> Date: Sat, 23 Oct 2010 09:46:30 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12pre) Gecko/20101020 Shredder/3.1.6pre MIME-Version: 1.0 To: Christopher Jones , internals@lists.php.net References: <4CB3066D.1030201@wafel.org> <4CB32122.5030004@oracle.com> In-Reply-To: <4CB32122.5030004@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Allowing an array as a parameter for snmpget()/snmpgetnext() [repost] From: jorrit@wafel.org (Jorrit Kronjee) Chris and others, Since SNMP didn't have any unit tests to begin with, I just looked at some examples. I guess I looked at the wrong ones (in the current version 5811 unit tests have the SKIPIF sections, compared to 5416 that do not). Before I start adding these, can someone tell me what to do to get this patch included? The maintainers of the SNMP extension have been silent so far. I would love to make this patch fly, but if it's just not going to happen then that's fine with me too. Regards, Jorrit Kronjee On 10/11/2010 04:37 PM, Christopher Jones wrote: > > Hi Jorrit, > > I'm not able to comment on the question of inclusion, but I did notice > that the .phpt > files are missing SKIPIF sections. See http://qa.php.net/write-test.php > > Chris > > On 10/11/2010 05:43 AM, Jorrit Kronjee wrote: >> Dear list, >> >> A few weeks ago I submitted the attached patch to this list. Apart from >> some initial comments I've not heard if the patch is good enough now to >> be added to the PHP sources. >> >> Is there anything still missing? >> >> Regards, >> >> Jorrit Kronjee >> >