Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49959
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <4CC2007E.2070703@divbyzero.net>
Date: Sat, 23 Oct 2010 00:05:29 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_IST?=
Message-ID: <op.vkz2ffviidpuyk@damnation.dulce.lo.geleia.net>
In-Reply-To: <4CC2007E.2070703@divbyzero.net>
User-Agent: Opera Mail/10.63 (Win32)
Subject: Re: [PHP-DEV] Storing zvals in hash tables in resources
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Fri, 22 Oct 2010 22:22:06 +0100, Martin Jansen <martin@divbyzero.net>  
wrote:

> I'm trying to store zvals in a hash table which is part of a resource.
> Unfortunately the zvals do not seem to "persist" between function calls:
>
> [...]
>
>     ALLOC_HASHTABLE(ctx->variables);
>     zend_hash_init(ctx->variables, 32, NULL, NULL, 0);
>

You probably want to give a destructor to zend_hash_init, since you're  
storing zvals, that would be ZVAL_PTR_DTOR.

> [...]
>     if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rsz",
>         &zcontext, &name, &name_len, &value) == FAILURE)
>     {
>         return;
>     }
>
>     ZEND_FETCH_RESOURCE(ctx, foo_context*, &zcontext, -1,
>         FOO_CONTEXT_RES_NAME, le_adl_context);
>
>     zend_hash_update(ctx->variables, name, name_len + 1, &value,
> sizeof(zval*), NULL);

You're not incrementing the refcount of the value you're adding to the  
hash table. Call zval_add_ref.


-- 
Gustavo Lopes