Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49884 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4238 invoked from network); 7 Oct 2010 13:44:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Oct 2010 13:44:10 -0000 Authentication-Results: pb1.pair.com smtp.mail=slugonamission@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=slugonamission@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: slugonamission@gmail.com X-Host-Fingerprint: 209.85.161.170 mail-gx0-f170.google.com Received: from [209.85.161.170] ([209.85.161.170:35480] helo=mail-gx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4C/70-01054-9AECDAC4 for ; Thu, 07 Oct 2010 09:44:10 -0400 Received: by gxk4 with SMTP id 4so308605gxk.29 for ; Thu, 07 Oct 2010 06:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=imkoOhyq/trKL0FazwWrgm/ivhzMN3KlQeBtbfFQXNY=; b=FdtOzPlpXjD18eUJKDE0mYeKoE0yNlopb15Sle1h6+MM8lw/i2hWwP0QEs74S//PXz R2oJ8BWFjRlO4thVrLOLZIV+75mnatOzyHLZcVawED/kxHip7nEO9eOmISsyzqeXzpmL XNCn8ZjBgZOEY0v8DFsTFp503NWp6cATsYY8Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=mYc4k0R4UupOdGJKqZO+yUUoc/Y+a14rH1P4+vjxi4dwzlsYvQenhZlcURuJbkUzN7 Df86zgA8ehjMpgCkJ7OZbdK5oFDxR/2CFKn4MsZsFCZamNLX+XQHvomsZIGqlJl9mwN8 EHDI2MSPl4D7wA8NBFWpTT/oT2My7GWhvnBoE= Received: by 10.42.1.1 with SMTP id 1mr838861ice.8.1286459046968; Thu, 07 Oct 2010 06:44:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.17.71 with HTTP; Thu, 7 Oct 2010 06:43:46 -0700 (PDT) Date: Thu, 7 Oct 2010 14:43:46 +0100 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=00235448f209834a2704920716b2 Subject: [PATCH] Docs say preg_match() returns FALSE on error, but it returns int(0) From: slugonamission@gmail.com (Jamie Garside) --00235448f209834a2704920716b2 Content-Type: multipart/alternative; boundary=00235448f209834a1304920716b0 --00235448f209834a1304920716b0 Content-Type: text/plain; charset=ISO-8859-1 This is a patch to fix "Bug #52732 Docs say preg_match() returns FALSE on error, but it returns int(0)" (http://bugs.php.net/bug.php?id=52732). The documentation states that preg_match should return FALSE on error, although it returns 0 if it breaks the recursion or backtrack limit. This just checks the error code before returning the number of matches. This also patches a couple of tests that relied on preg_match returning 0 on error. ~Jamie --00235448f209834a1304920716b0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable This is a patch to fix "Bug=A0#52732 Docs say preg_match() returns FALSE on error, but it returns int(0)"= ; (http://bugs.php.net/b= ug.php?id=3D52732).

The documentation states that preg_match sho= uld return FALSE on error, although it returns 0 if it breaks the recursion= or backtrack limit. This just checks the error code before returning the n= umber of matches. This also patches a couple of tests that relied on preg_m= atch returning 0 on error.

~Jamie
--00235448f209834a1304920716b0-- --00235448f209834a2704920716b2 Content-Type: text/plain; charset=US-ASCII; name="bug52732_patch.txt" Content-Disposition: attachment; filename="bug52732_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gezohcfl0 SW5kZXg6IGV4dC9wY3JlL3BocF9wY3JlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZXh0L3BjcmUvcGhwX3Bj cmUuYwkocmV2aXNpb24gMzA0MTY0KQorKysgZXh0L3BjcmUvcGhwX3BjcmUuYwkod29ya2luZyBj b3B5KQpAQCAtNzU0LDcgKzc1NCwxMyBAQAogCWVmcmVlKG9mZnNldHMpOwogCWVmcmVlKHN1YnBh dF9uYW1lcyk7CiAKLQlSRVRWQUxfTE9ORyhtYXRjaGVkKTsKKwkvKiBEaWQgd2UgZW5jb3VudGVy IGFuIGVycm9yPyAqLworCWlmKFBDUkVfRyhlcnJvcl9jb2RlKSA9PSBQSFBfUENSRV9OT19FUlJP UikgeworCQlSRVRWQUxfTE9ORyhtYXRjaGVkKTsKKwl9CisJZWxzZSB7CisJCVJFVFZBTF9GQUxT RTsKKwl9CiB9CiAvKiB9fX0gKi8KIApJbmRleDogZXh0L3BjcmUvdGVzdHMvYnVnNTI3MzIucGhw dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBleHQvcGNyZS90ZXN0cy9idWc1MjczMi5waHB0CShyZXZpc2lvbiAw KQorKysgZXh0L3BjcmUvdGVzdHMvYnVnNTI3MzIucGhwdAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxMyBAQAorLS1URVNULS0KK0J1ZyAjNTI3MzIgKERvY3Mgc2F5IHByZWdfbWF0Y2goKSByZXR1 cm5zIEZBTFNFIG9uIGVycm9yLCBidXQgaXQgcmV0dXJucyBpbnQoMCkpCistLUlOSS0tCitwY3Jl LmJhY2t0cmFja19saW1pdD0xCistLUZJTEUtLQorPD9waHAKKyRyZXQgPSBwcmVnX21hdGNoKCcv KD86XEQrfDxcZCs+KSpbIT9dLycsICdmb29iYXIgZm9vYmFyIGZvb2JhcicpOworCit2YXJfZHVt cCgkcmV0KTsKKworPz4KKy0tRVhQRUNULS0KK2Jvb2woZmFsc2UpClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQpJbmRleDogZXh0L3BjcmUvdGVzdHMvYmFja3RyYWNrX2xpbWl0LnBocHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gZXh0L3BjcmUvdGVzdHMvYmFja3RyYWNrX2xpbWl0LnBocHQJKHJldmlzaW9u IDMwNDE2NCkKKysrIGV4dC9wY3JlL3Rlc3RzL2JhY2t0cmFja19saW1pdC5waHB0CSh3b3JraW5n IGNvcHkpCkBAIC0xOSw3ICsxOSw3IEBACiAKID8+CiAtLUVYUEVDVC0tCi1pbnQoMCkKK2Jvb2wo ZmFsc2UpCiBib29sKHRydWUpCiBpbnQoMTApCiBib29sKHRydWUpCkluZGV4OiBleHQvcGNyZS90 ZXN0cy9pbnZhbGlkX3V0Zjhfb2Zmc2V0LnBocHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZXh0L3BjcmUvdGVz dHMvaW52YWxpZF91dGY4X29mZnNldC5waHB0CShyZXZpc2lvbiAzMDQxNjQpCisrKyBleHQvcGNy ZS90ZXN0cy9pbnZhbGlkX3V0Zjhfb2Zmc2V0LnBocHQJKHdvcmtpbmcgY29weSkKQEAgLTIyLDcg KzIyLDcgQEAKIGVjaG8gIkRvbmVcbiI7CiA/PgogLS1FWFBFQ1QtLQotaW50KDApCitib29sKGZh bHNlKQogYXJyYXkoMCkgewogfQogYm9vbCh0cnVlKQpJbmRleDogZXh0L3BjcmUvdGVzdHMvcmVj dXJzaW9uX2xpbWl0LnBocHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZXh0L3BjcmUvdGVzdHMvcmVjdXJzaW9u X2xpbWl0LnBocHQJKHJldmlzaW9uIDMwNDE2NCkKKysrIGV4dC9wY3JlL3Rlc3RzL3JlY3Vyc2lv bl9saW1pdC5waHB0CSh3b3JraW5nIGNvcHkpCkBAIC0xOSw3ICsxOSw3IEBACiAKID8+CiAtLUVY UEVDVC0tCi1pbnQoMCkKK2Jvb2woZmFsc2UpCiBib29sKHRydWUpCiBpbnQoMSkKIGJvb2wodHJ1 ZSkK --00235448f209834a2704920716b2--