Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49863
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=GbGHRmF8vhVo77lad25EK2QNJsFmvLq+xQEaTIqMGIP3f/t8sFB9g8xKAHLGWyJgnr
         /WyafutNujNhsSP8lm7L9bk+AWGi+3AvvILYlo/+z3fP0bdERIbtye/3gZ0UIWx0ayin
         yhtXn0lIFH4zjuH5AB8eD5Um0wHa62nnk1wn8=
MIME-Version: 1.0
In-Reply-To: <AANLkTim+VUE=1Xi3hD4JF5RmaDymH3+CdBNK+hYrFGB7@mail.gmail.com>
References: <4CA6885F.3040709@sugarcrm.com>
	<alpine.DEB.2.00.1010031928290.2461@kossu.derickrethans.nl>
	<AANLkTikk4Je0LE-bc3mNTiS=UPqvaSM9D_N9SN_GV0O8@mail.gmail.com>
	<4CA91151.2010104@sugarcrm.com>
	<AANLkTimZ_U+raT7q9yQ=ZoDzbknf5x53+Y9egDT50hZ6@mail.gmail.com>
	<alpine.DEB.2.00.1010040940550.2461@kossu.derickrethans.nl>
	<AANLkTim+VUE=1Xi3hD4JF5RmaDymH3+CdBNK+hYrFGB7@mail.gmail.com>
Date: Mon, 4 Oct 2010 13:17:59 +0200
Message-ID: <AANLkTinNyL063XpPuqCROiOb80nHTWNb61B1ErXMFvQF@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Derick Rethans <derick@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] rfc2616 datetime format?
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Mon, Oct 4, 2010 at 11:29, Pierre Joye <pierre.php@gmail.com> wrote:
> On Mon, Oct 4, 2010 at 10:42 AM, Derick Rethans <derick@php.net> wrote:
>> On Mon, 4 Oct 2010, Pierre Joye wrote:
>>
>>> On Mon, Oct 4, 2010 at 1:27 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
>>> >
>>> >> It looks like a sub optimal choice to have used string constants
>>> >> instead of integer. However it could be still possible to define new
>>> >> constants as numeric. It is then possible to do whatever needs to be
>>> >> done as post or pre ops for the respective constants.
>>> >
>>> > I'm not sure what integers have to do with it? The constants define date
>>> > formats that are in common use, RFC2616 is one of the commonest on the web
>>> > and we don't have a constant for it...
>>>
>>> I mean in ext/date and as a reply to Derick, not your request which is
>>> totally valid. A date time object has the timezone information. If the
>>> constants were integers, it would be very straightforward to do some
>>> operations before calling the formatting functions depending on a
>>> given predefined format. It should still be possible to do it by
>>> testing the string contents (strncmp), but that's not very clean.
>>
>> Stop talking about something you don't know anything about, please.
>> Those constants are not *one* format letter, they are many. Maybe you
>> could have tried this:
>>
>> echo DateTime::RFC822, "\n";
>
> Maybe you could read what I wrote instead of replying in such stupid
> manner, that could lead the discussions in a constructive direction,
> thanks.
>
> Key parts were:
>
> 1. using integer makes such features easier to implement (basic good
> practice/programming 101)
> 2. use strncmp to compare the format (yes, strncmp supports many characters)



Are you proposing that the constants become integers?
so, DATE_RFC_1234 will be equal to "1234"?

And then date(DATE_RFC_1234); will print out formatted string?

I am afraid that would break craploads of applications, and become
very confusing.

-Hannes