Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49862
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=DnB7lByO6IFKMjfreXM+NoEr3BCeudMOZlKK//dznpc1wX/bOtKHub5JJN2FgVLIrD
         +FAh5waMJpZNCXKcvW2subAiduoGMyU9EadFEgn0k39gKZ930c2PXX7JyeDZ+LAWB0wO
         VHRTOqXE+0zpUIlYyVEj0GbF7CKAXgSW4WLDc=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1010040940550.2461@kossu.derickrethans.nl>
References: <4CA6885F.3040709@sugarcrm.com>
	<alpine.DEB.2.00.1010031928290.2461@kossu.derickrethans.nl>
	<AANLkTikk4Je0LE-bc3mNTiS=UPqvaSM9D_N9SN_GV0O8@mail.gmail.com>
	<4CA91151.2010104@sugarcrm.com>
	<AANLkTimZ_U+raT7q9yQ=ZoDzbknf5x53+Y9egDT50hZ6@mail.gmail.com>
	<alpine.DEB.2.00.1010040940550.2461@kossu.derickrethans.nl>
Date: Mon, 4 Oct 2010 11:29:00 +0200
Message-ID: <AANLkTim+VUE=1Xi3hD4JF5RmaDymH3+CdBNK+hYrFGB7@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] rfc2616 datetime format?
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Oct 4, 2010 at 10:42 AM, Derick Rethans <derick@php.net> wrote:
> On Mon, 4 Oct 2010, Pierre Joye wrote:
>
>> On Mon, Oct 4, 2010 at 1:27 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
>> >
>> >> It looks like a sub optimal choice to have used string constants
>> >> instead of integer. However it could be still possible to define new
>> >> constants as numeric. It is then possible to do whatever needs to be
>> >> done as post or pre ops for the respective constants.
>> >
>> > I'm not sure what integers have to do with it? The constants define date
>> > formats that are in common use, RFC2616 is one of the commonest on the web
>> > and we don't have a constant for it...
>>
>> I mean in ext/date and as a reply to Derick, not your request which is
>> totally valid. A date time object has the timezone information. If the
>> constants were integers, it would be very straightforward to do some
>> operations before calling the formatting functions depending on a
>> given predefined format. It should still be possible to do it by
>> testing the string contents (strncmp), but that's not very clean.
>
> Stop talking about something you don't know anything about, please.
> Those constants are not *one* format letter, they are many. Maybe you
> could have tried this:
>
> echo DateTime::RFC822, "\n";

Maybe you could read what I wrote instead of replying in such stupid
manner, that could lead the discussions in a constructive direction,
thanks.

Key parts were:

1. using integer makes such features easier to implement (basic good
practice/programming 101)
2. use strncmp to compare the format (yes, strncmp supports many characters)

2. is bad as it has the side effects of applying to a format given
manually even if one did not intend to use it this way, it could have
BC issues but I'm not sure at all if such format exists.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org