Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49787 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87470 invoked from network); 25 Sep 2010 02:17:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Sep 2010 02:17:48 -0000 Authentication-Results: pb1.pair.com header.from=kris.craig@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=kris.craig@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: kris.craig@gmail.com X-Host-Fingerprint: 74.125.82.54 mail-ww0-f54.google.com Received: from [74.125.82.54] ([74.125.82.54:36964] helo=mail-ww0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A4/B0-15184-ACB5D9C4 for ; Fri, 24 Sep 2010 22:17:47 -0400 Received: by wwb22 with SMTP id 22so3912861wwb.11 for ; Fri, 24 Sep 2010 19:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=bPjKaAlg6IgmWQXCRqHyU8HKXzaK+iF68ol3vbfa2RQ=; b=I8x1YO66aIwG13gFniuozi0qVA8LZ9TvI83v4Dx43hGKo0I2hppk6QXA7uDlOt28am DvondBEDaWPyP62DUBao3fgf2FPWqUmQpORcgb9w2Kp6lte2xlMMz58/TF77ugZakF5H YktjebgbYxSt0mKnlYj4SDs+cxtN9/HwbuNkI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=U7992LamYT5H8IR+0mNGJSePyyXHCezisTDoDkwAaIbuVw11PRfIl8m5be+A03YEVY z6200msBZLq3kGmgE4+kfIDF/wi8WNUAoGQcMoPdrKNHGIqSpxUbKFtsM93XTQKG9PJg +jyzLvNSAwIO9DzBELq4NdTUUVOsC38br1BoM= MIME-Version: 1.0 Received: by 10.216.6.133 with SMTP id 5mr10173551wen.32.1285381063851; Fri, 24 Sep 2010 19:17:43 -0700 (PDT) Received: by 10.216.25.70 with HTTP; Fri, 24 Sep 2010 19:17:43 -0700 (PDT) In-Reply-To: References: <1281428839.969.2038.camel@guybrush> <4C61AD77.5080109@php.net> Date: Fri, 24 Sep 2010 19:17:43 -0700 Message-ID: To: Derick Rethans Cc: internals@lists.php.net Content-Type: multipart/mixed; boundary=0016364d253bb63f4004910c1984 Subject: Re: [PHP-DEV] SVN Account Request: kriscraig From: kris.craig@gmail.com (Kris Craig) --0016364d253bb63f4004910c1984 Content-Type: multipart/alternative; boundary=0016364d253bb63f3304910c1982 --0016364d253bb63f3304910c1982 Content-Type: text/plain; charset=ISO-8859-1 It's been a couple months since I heard anything, so I wanted to check the status of my request and update you on my efforts. Things got pretty busy so I didn't have much time to work on this in August, but the last couple weeks I've been able to really dive into it. The latest patch is attached (based off 5.3.3 r303757 now). As you can see, it's no longer just a hacky proof-of-concept like the previous patch sent out. This actually makes full use of the formulas and has been thoroughly tested. The only issue I'm running into is precision. You'll notice I've got a ton of type casting all over the place (including a lot of unnecessary long doubles lol) which I'll have cleaned-up in the next patch. These formulas are accurate to within a few seconds (over the next several thousand years at least), but the level of precision required is a bit much for standard floating points to handle. As a result, the equinox/solstice start dates are off by about 6-14 minutes when compiled on stock Ubuntu 10.04 and 0-7 minutes when compiled on Windows (VC9). Is the PHP source currently making use of any arbitrary precision libraries (like MPFR, etc) anywhere? That would easily solve this rounding issue and enable me to put together some PHPT tests with predictable results. Also, I would like to ping for an update on my SVN account request. If there is anything further you need me to do for you in order to complete this process, I will be more than happy to do it. Thanks! --Kris On Tue, Aug 10, 2010 at 1:36 PM, Kris Craig wrote: > Woops, sorry. Here's the file renamed to .txt. Thanks for the tip! > > > --Kris > > > > On Tue, Aug 10, 2010 at 12:50 PM, Michael Maclean wrote: > >> On 10/08/10 20:28, Kris Craig wrote: >> >>> Sorry, I guess it would help if I actually attached the patch..... Here >>> it is. >>> >> >> The list strips attachments with filenames ending in something other than >> .txt - resend or perhaps put it online somewhere? >> >> -- >> Cheers, >> Michael >> > > --0016364d253bb63f3304910c1982 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable It's been a couple months since I heard anything, so I wanted to check = the status of my request and update you on my efforts.=A0 Things got pretty= busy so I didn't have much time to work on this in August, but the las= t couple weeks I've been able to really dive into it.

The latest patch is attached (based off 5.3.3 r303757 now).=A0 As you c= an see, it's no longer just a hacky proof-of-concept like the previous = patch sent out.=A0 This actually makes full use of the formulas and has bee= n thoroughly tested.

The only issue I'm running into is precision.=A0 You'll notice = I've got a ton of type casting all over the place (including a lot of u= nnecessary long doubles lol) which I'll have cleaned-up in the next pat= ch.=A0 These formulas are accurate to within a few seconds (over the next s= everal thousand years at least), but the level of precision required is a b= it much for standard floating points to handle.=A0 As a result, the equinox= /solstice start dates are off by about 6-14 minutes when compiled on stock = Ubuntu 10.04 and 0-7 minutes when compiled on Windows (VC9).=A0 Is the PHP = source currently making use of any arbitrary precision libraries (like MPFR= , etc) anywhere?=A0 That would easily solve this rounding issue and enable = me to put together some PHPT tests with predictable results.


Also, I would like to ping for an update on my SVN account request.= =A0 If there is anything further you need me to do for you in order to comp= lete this process, I will be more than happy to do it.


Thanks!
--Kris


On Tue, Aug 10, 2010 at 1:= 36 PM, Kris Craig <kris.craig@gmail.com> wrote:
Woops, sorry.=A0 Here's the file renamed to .txt.=A0 Thanks for the tip= !


--Kris



On Tue, Aug 10, 2010 at 12:= 50 PM, Michael Maclean <mgdm@php.net> wrote:
On 10/08/10 = 20:28, Kris Craig wrote:
Sorry, I guess it would help if I actually attached the patch..... =A0Here<= br> it is.

The list strips attachments with filenames ending in something other than .= txt - resend or perhaps put it online somewhere?

--
Cheers,
Michael


--0016364d253bb63f3304910c1982-- --0016364d253bb63f4004910c1984 Content-Type: text/plain; charset=US-ASCII; name="php_date_seasons.txt" Content-Disposition: attachment; filename="php_date_seasons.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gehukt4z1 LS0tIHBocF9kYXRlLmNfZGlmZmJhc2UuYwlGcmkgU2VwIDI0IDE4OjUwOjA5IDIwMTANCisrKyBw aHBfZGF0ZS5jCUZyaSBTZXAgMjQgMTg6MTc6MDYgMjAxMA0KQEAgLTk2Nyw2ICs5NjcsMTAgQEAN CiAJIlN1biIsICJNb24iLCAiVHVlIiwgIldlZCIsICJUaHUiLCAiRnJpIiwgIlNhdCINCiB9Ow0K IA0KK3N0YXRpYyBjaGFyICpzZWFzb25fbmFtZXNbXSA9IHsNCisJIldpbnRlciIsICJTcHJpbmci LCAiU3VtbWVyIiwgIkZhbGwiDQorfTsNCisNCiBzdGF0aWMgY2hhciAqZW5nbGlzaF9zdWZmaXgo dGltZWxpYl9zbGwgbnVtYmVyKQ0KIHsNCiAJaWYgKG51bWJlciA+PSAxMCAmJiBudW1iZXIgPD0g MTkpIHsNCkBAIC05ODIsNiArOTg2LDE2MiBAQA0KIH0NCiAvKiB9fX0gKi8NCiANCisvKiB7e3sg QXN0cm9ub21pY2FsIHNlYXNvbiBlcXVpbm94L3NvbHN0aWNlIGNhbGN1bGF0aW9ucy4gIC0tS3Jp cyAqLw0KK2xvbmcgZG91YmxlIHBocF9kYXRlX2dldF9lcXVpbm94X2pkZSggaW50IHksIGludCBz ZWFzb24gKQ0KK3sNCisJbG9uZyBkb3VibGUgamRlLCB5MjsNCisJDQorCS8vRXF1YXRpb25zIGRl cml2ZWQgZnJvbSAiQXN0cm9ub21pY2FsIEFsZ29yaXRobXMiIGJ5IEplYW4gTWVldXMuICAtLUty aXMNCisJDQorCXkyID0gKGxvbmcgZG91YmxlKSAoKGludCkgeSAtIDIwMDApIC8gMTAwMDsNCisJ DQorCXN3aXRjaCAoIChpbnQpIHNlYXNvbiApDQorCXsNCisJCWRlZmF1bHQ6DQorCQljYXNlIDA6 DQorCQkJLy9EZWNlbWJlciBzb2xzdGljZSwgc3RhcnQgb2Ygd2ludGVyLiAgLS1LcmlzDQorCQkJ amRlID0gMjQ1MTkwMC4wNTk1MiArICgzNjUyNDIuNzQwNDkgKiB5MikgLSAoMC4wNjIyMyAqIHBv dyggeTIsIDIgKSkgLSAoMC4wMDgyMyAqIHBvdyggeTIsIDMgKSkgKyAoMC4wMDAzMiAqIHBvdygg eTIsIDQgKSk7DQorCQkJYnJlYWs7DQorCQljYXNlIDE6DQorCQkJLy9NYXJjaCBlcXVpbm94LCBz dGFydCBvZiBzcHJpbmcuICAtLUtyaXMNCisJCQlqZGUgPSAyNDUxNjIzLjgwOTg0ICsgKDM2NTI0 Mi4zNzQwNCAqIHkyKSArICgwLjA1MTY5ICogcG93KCB5MiwgMiApKSAtICgwLjAwNDExICogcG93 KCB5MiwgMyApKSAtICgwLjAwMDU3ICogcG93KCB5MiwgNCApKTsNCisJCQlicmVhazsNCisJCWNh c2UgMjoNCisJCQkvL0p1bmUgc29sc3RpY2UsIHN0YXJ0IG9mIHN1bW1lci4gIC0tS3Jpcw0KKwkJ CWpkZSA9IDI0NTE3MTYuNTY3NjcgKyAoMzY1MjQxLjYyNjAzICogeTIpICsgKDAuMDAzMjUgKiBw b3coIHkyLCAyICkpICsgKDAuMDA4ODggKiBwb3coIHkyLCAzICkpIC0gKDAuMDAwMzAgKiBwb3co IHkyLCA0ICkpOw0KKwkJCWJyZWFrOw0KKwkJY2FzZSAzOg0KKwkJCS8vU2VwdGVtYmVyIGVxdWlu b3gsIHN0YXJ0IG9mIGZhbGwuICAtLUtyaXMNCisJCQlqZGUgPSAyNDUxODEwLjIxNzE1ICsgKDM2 NTI0Mi4wMTc2NyAqIHkyKSAtICgwLjExNTc1ICogcG93KCB5MiwgMiApKSArICgwLjAwMzM3ICog cG93KCB5MiwgMyApKSArICgwLjAwMDc4ICogcG93KCB5MiwgNCApKTsNCisJCQlicmVhazsNCisJ fQ0KKwkNCisJcmV0dXJuIGpkZTsNCit9DQorDQoraW50IGdyZWdvcmlhbl9iYXNlX2Zyb21famQo IGRvdWJsZSBqZCApDQorew0KKwlkb3VibGUgWiwgQSwgYTsNCisJDQorCWpkICs9IDAuNTsNCisJ DQorCVogPSAoaW50KSBqZDsNCisJDQorCWlmICggWiA8IDIyOTkxNjEgKQ0KKwl7DQorCQlBID0g WjsNCisJfQ0KKwllbHNlDQorCXsNCisJCWEgPSAoaW50KSAoKFogLSAxODY3MjE2LjI1KSAvIDM2 NTI0LjI1KTsNCisJCUEgPSBaICsgMSArIGEgLSAoaW50KSAoYSAvIDQpOw0KKwl9DQorCQ0KKwly ZXR1cm4gKEEgKyAxNTI0KTsNCit9DQorDQorZG91YmxlIGRheW9mbW9udGhfZnJvbV9qZCggZG91 YmxlIGpkICkNCit7DQorCWRvdWJsZSBCLCBDLCBELCBFOyAgLy9BbWJpZ3VpdHkgYXNpZGUsIEkn bSBqdXN0IGtlZXBpbmcgdGhlIHZhcmlhYmxlIG5hbWVzIGNvbnNpc3RlbnQgd2l0aCB0aGUgb3Jp Z2luYWwgZm9ybXVsYXMuICAtLUtyaXMNCisJZG91YmxlIEY7DQorCQ0KKwlCID0gKGludCkgZ3Jl Z29yaWFuX2Jhc2VfZnJvbV9qZCggamQgKTsNCisJQyA9IChpbnQpICgoQiAtIDEyMi4xKSAvIDM2 NS4yNSk7DQorCUQgPSAoaW50KSAoMzY1LjI1ICogQyk7DQorCUUgPSAoaW50KSAoKEIgLSBEKSAv IDMwLjYwMDEpOw0KKwlGID0gKGRvdWJsZSkgKGpkICsgMC4wNSkgLSAoaW50KSAoamQgKyAwLjA1 KTsNCisJDQorCXJldHVybiAoQiAtIEQgLSAoaW50KSAoMzAuNjAwMSAqIEUpICsgRik7DQorfQ0K Kw0KK2ludCBtb250aF9mcm9tX2pkKCBkb3VibGUgamQgKQ0KK3sNCisJaW50IEIsIEMsIEQsIEU7 ICAvL0FtYmlndWl0eSBhc2lkZSwgSSdtIGp1c3Qga2VlcGluZyB0aGUgdmFyaWFibGUgbmFtZXMg Y29uc2lzdGVudCB3aXRoIHRoZSBvcmlnaW5hbCBmb3JtdWxhcy4gIC0tS3Jpcw0KKwlkb3VibGUg RjsNCisJDQorCUIgPSAoaW50KSBncmVnb3JpYW5fYmFzZV9mcm9tX2pkKCBqZCApOw0KKwlDID0g KGludCkgKChCIC0gMTIyLjEpIC8gMzY1LjI1KTsNCisJRCA9IChpbnQpICgzNjUuMjUgKiBDKTsN CisJRSA9IChpbnQpICgoQiAtIEQpIC8gMzAuNjAwMSk7DQorCUYgPSAoZG91YmxlKSAoamQgKyAw LjA1KSAtIChpbnQpIChqZCArIDAuMDUpOw0KKwkNCisJaWYgKCBFIDwgMTQgKQ0KKwl7DQorCQly ZXR1cm4gKEUgLSAxKTsNCisJfQ0KKwllbHNlDQorCXsNCisJCXJldHVybiAoRSAtIDEzKTsNCisJ fQ0KK30NCisNCitpbnQgeWVhcl9mcm9tX2pkKCBkb3VibGUgamQgKQ0KK3sNCisJZG91YmxlIEIs IEM7DQorCQ0KKwlCID0gKGludCkgZ3JlZ29yaWFuX2Jhc2VfZnJvbV9qZCggamQgKTsNCisJQyA9 IChpbnQpICgoQiAtIDEyMi4xKSAvIDM2NS4yNSk7DQorCQ0KKwlpZiAoIG1vbnRoX2Zyb21famQo IGpkICkgPiAyICkNCisJew0KKwkJcmV0dXJuIChDIC0gNDcxNik7DQorCX0NCisJZWxzZQ0KKwl7 DQorCQlyZXR1cm4gKEMgLSA0NzE1KTsNCisJfQ0KK30NCisNCitkb3VibGUgZGF5X2V4YWN0KCBk b3VibGUgZCwgZG91YmxlIGgsIGRvdWJsZSBpLCBkb3VibGUgcyApDQorew0KKwlyZXR1cm4gKGRv dWJsZSkgKGQgKyAoaCAvIDI0KSArIChpIC8gKDI0ICogNjApKSArIChzIC8gKDI0ICogcG93KCA2 MCwgMiApKSkpOw0KK30NCisNCitkb3VibGUgamRfZnJvbV9kYXRlKCBkb3VibGUgeSwgZG91Ymxl IG0sIGRvdWJsZSBkICkNCit7DQorCS8qIE91ciB3b3JraW5nIGZvcm11bGEgdmFyaWFibGVzLiAg LS1LcmlzICovDQorCWRvdWJsZSBBLCBCOw0KKwkNCisJLyogSWYgSmFuIG9yIEZlYiwgaXQncyBj b25zaWRlcmVkIHRvIGJlIHRoZSAxM3RoIG9yIDE0dGggbW9udGggb2YgdGhlIHByZWNlZGluZyB5 ZWFyLiAgLS1LcmlzICovDQorCWlmICggbSA8PSAyICkNCisJew0KKwkJbSArPSAxMjsNCisJCXkt LTsNCisJfQ0KKwkNCisJQSA9IChpbnQpICh5IC8gMTAwKTsNCisJQiA9IDIgLSBBICsgKGludCkg KEEgLyA0KTsNCisJDQorCXJldHVybiAoZG91YmxlKSAoKGludCkgKDM2NS4yNSAqICh5ICsgNDcx NikpICsgKGludCkgKDMwLjYwMDEgKiAobSArIDEpKSArIGQgKyBCIC0gMTUyNC41KTsNCit9DQor DQorLyogfX19ICovDQorDQorLyoge3t7IEdldCB0aGUgY3VycmVudCBzZWFzb24uICBJZiBoZW1p c3BoZXJlIGNhbm5vdCBiZSBkZXRlcm1pbmVkLCBhc3N1bWUgbm9ydGguICAtLUtyaXMgKi8NCitp bnQgcGhwX2RhdGVfZ2V0X3NlYXNvbiggZG91YmxlIHksIGRvdWJsZSBtLCBkb3VibGUgZCwgZG91 YmxlIGgsIGRvdWJsZSBpLCBkb3VibGUgcywgY2hhciAqdGltZXpvbmUgKQ0KK3sNCisJZG91Ymxl IGhlbWlzcGhlcmUsIHNlYXNvbiwgc2xvb3A7DQorCWRvdWJsZSBqZDsNCisJDQorCS8vVE9ETyAt IHJldHVybiAoU2Vhc29uIyArIEhlbWlzcGhlcmUjKSAlIDQ7ICAvL1doZXJlIEhlbWlzcGhlcmUj IGlzIDAgZm9yIE5vcnRoLCAyIGZvciBTb3V0aC4gIC0tS3Jpcw0KKwloZW1pc3BoZXJlID0gMDsN CisJDQorCWpkID0gamRfZnJvbV9kYXRlKCB5LCBtLCBkYXlfZXhhY3QoIChkb3VibGUpIGQsIChk b3VibGUpIGgsIChkb3VibGUpIGksIChkb3VibGUpIHMgKSApOw0KKwkNCisJc2Vhc29uID0gMDsN CisJZm9yICggc2xvb3AgPSA0OyBzbG9vcCA+IDA7IHNsb29wLS0gKQ0KKwl7DQorCQlpZiAoIGpk ID49IHBocF9kYXRlX2dldF9lcXVpbm94X2pkZSggeSwgKChpbnQpIHNsb29wICUgNCkgKSApDQor CQl7DQorCQkJc2Vhc29uID0gKChpbnQpIHNsb29wICUgNCk7DQorCQkJYnJlYWs7DQorCQl9DQor CX0NCisJDQorCXJldHVybiAoaW50KSAoc2Vhc29uICsgaGVtaXNwaGVyZSkgJSA0Ow0KK30NCisv KiB9fX0gKi8NCisNCiAvKiB7e3sgZGF5IG9mIHdlZWsgaGVscGVycyAqLw0KIGNoYXIgKnBocF9k YXRlX2Z1bGxfZGF5X25hbWUodGltZWxpYl9zbGwgeSwgdGltZWxpYl9zbGwgbSwgdGltZWxpYl9z bGwgZCkNCiB7DQpAQCAtMTA2Nyw2ICsxMjI3LDEyIEBADQogCQkJY2FzZSAnTCc6IGxlbmd0aCA9 IHNscHJpbnRmKGJ1ZmZlciwgMzIsICIlZCIsIHRpbWVsaWJfaXNfbGVhcCgoaW50KSB0LT55KSk7 IGJyZWFrOw0KIAkJCWNhc2UgJ3knOiBsZW5ndGggPSBzbHByaW50ZihidWZmZXIsIDMyLCAiJTAy ZCIsIChpbnQpIHQtPnkgJSAxMDApOyBicmVhazsNCiAJCQljYXNlICdZJzogbGVuZ3RoID0gc2xw cmludGYoYnVmZmVyLCAzMiwgIiVzJTA0bGxkIiwgdC0+eSA8IDAgPyAiLSIgOiAiIiwgcGhwX2Rh dGVfbGxhYnMoKHRpbWVsaWJfc2xsKSB0LT55KSk7IGJyZWFrOw0KKwkJCQ0KKwkJCS8qIHNlYXNv biAqLw0KKwkJCWNhc2UgJ3YnOiBsZW5ndGggPSBzbHByaW50ZihidWZmZXIsIDMyLCAiJXMiLCBz ZWFzb25fbmFtZXNbKGludCkgcGhwX2RhdGVfZ2V0X3NlYXNvbiggKGRvdWJsZSkgdC0+eSwgKGRv dWJsZSkgdC0+bSwgKGRvdWJsZSkgdC0+ZCwgDQorCQkJCShkb3VibGUpIHQtPmgsIChkb3VibGUp IHQtPmksIChkb3VibGUpIHQtPnMsIA0KKwkJCQlsb2NhbHRpbWUgJiYgdC0+em9uZV90eXBlID09 IFRJTUVMSUJfWk9ORVRZUEVfSUQgPyB0LT50el9pbmZvLT5uYW1lIDogIiIgKV0pOyBicmVhazsN CiANCiAJCQkvKiB0aW1lICovDQogCQkJY2FzZSAnYSc6IGxlbmd0aCA9IHNscHJpbnRmKGJ1ZmZl ciwgMzIsICIlcyIsIHQtPmggPj0gMTIgPyAicG0iIDogImFtIik7IGJyZWFrOw0K --0016364d253bb63f4004910c1984--