Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49775 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51097 invoked from network); 20 Sep 2010 23:36:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Sep 2010 23:36:56 -0000 Authentication-Results: pb1.pair.com header.from=chrisstocktonaz@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=chrisstocktonaz@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: chrisstocktonaz@gmail.com X-Host-Fingerprint: 74.125.82.170 mail-wy0-f170.google.com Received: from [74.125.82.170] ([74.125.82.170:55325] helo=mail-wy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D7/1F-07381-810F79C4 for ; Mon, 20 Sep 2010 19:36:56 -0400 Received: by wyf19 with SMTP id 19so5217357wyf.29 for ; Mon, 20 Sep 2010 16:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=m0N3vg1ZqtVW+caCbNlDF8CKh1n7scl0Z49cQzpYFpQ=; b=NcLivG18xRb9PdTTqwG8Js/SAFQOvTOoQ3eiA6nTcGeh4tyEOo3+GHKGvhaTeMyD9g iq72dQLJjRmDh90HLmGxhXdKLv+ycD+lZPVFbX7JwWswmWdRL9LLblmBrfT2HHebwJXS SJEwl98NQqA4820ymDwKm03sZnust/Bee0Y1g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=sAODD9MKvw3ytWabqbWTLgre/mhutpLad4KY0NKR/UznRiohVg+SxPOEIHCJqvh961 SS2eFUFALoFPuJOa3b58mXkzSmumDWw6yh/kYbq6rWXDQlTSuE0IjrvdQsaZhxg6fOI5 LB9rRmgGNEOnjrgyipo1uSaRet3jN89p9SnPw= MIME-Version: 1.0 Received: by 10.216.164.66 with SMTP id b44mr4969400wel.81.1285025813600; Mon, 20 Sep 2010 16:36:53 -0700 (PDT) Received: by 10.216.208.33 with HTTP; Mon, 20 Sep 2010 16:36:53 -0700 (PDT) In-Reply-To: <4C97CF70.6080701@php.net> References: <4C97BA1B.8070601@wafel.org> <4C97CF70.6080701@php.net> Date: Mon, 20 Sep 2010 16:36:53 -0700 Message-ID: To: Michael Maclean Cc: Jorrit Kronjee , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [PATCH] Allowing an array as a parameter for snmpget()/snmpgetnext() From: chrisstocktonaz@gmail.com (Chris Stockton) Hello, On Mon, Sep 20, 2010 at 2:17 PM, Michael Maclean wrote: > On 20/09/10 20:46, Jorrit Kronjee wrote: >> >> =A0Dear list, >> >> To better reflect the behavior of the snmpget command that comes with >> the Net-SNMP package the patch attached makes an array of OIDs as a >> parameter for the snmpget()/snmpgetnext() function possible. > > > > Looks good to me, for what it's worth. Anyone got objections? > I think the patch at a first glance looks good, although it is a minor cosmetic nitpick, I did catch a line with a couple of extra semi-colons. static void php_snmpv3(INTERNAL_FUNCTION_PARAMETERS, int st) { - char *a1, *a2, *a3, *a4, *a5, *a6, *a7, *a8; - int a1_len, a2_len, a3_len, a4_len, a5_len, a6_len, a7_len, a8_len; + char *a1, *a2, *a3, *a4, *a5, *a6, *a7, *a8;; + int a1_len, a2_len, a3_len, a4_len, a5_len, a6_len, a7_len, a8_len;; This patch does move around a bit of code, are there some tests to go along with this patch? -Chris