Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49552
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=KifInb+iZNUK4IExRzF7TbEcEp/DQEwaaT7ARrtKBRGbsrjZ1Oi8PNmBp2rOnE5CdQ
         PKnu1jQ0FwGd8t3HoWxQGeCF19BXXr1UNuPCL8bcCYtF4uftFNs2lVBRIeph3aBZmyuX
         QH4nWiw5y17paAtTounVbyqd7XWIilHdInv5I=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <AANLkTimgQZvKX9CVFbux5ZLvusTF9KsWbnU7iVYBYGd8@mail.gmail.com>
References: <AANLkTimgQZvKX9CVFbux5ZLvusTF9KsWbnU7iVYBYGd8@mail.gmail.com>
Date: Sat, 28 Aug 2010 02:19:45 +0200
Message-ID: <AANLkTinqJb_usCq45ygq6KDi_iE3yyT-F_GF8N+yJUKR@mail.gmail.com>
To: Pierrick Charron <pierrick@webstart.fr>, Guilherme Blanco <guilhermeblanco@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Annotation RFC + Patch
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Pierrick, Guilherme

2010/8/25 Pierrick Charron <pierrick@webstart.fr>:
> I'm here to propose a new feature in PHP: Annotations.
> A patch is already available with 54 tests for the moment[2].
>
> I worked together with Guilherme Blanco to make this support happen in
> a fresh PHP SVN trunk checkout.
> Please review, comment and provide feedback! I think it's a very
> useful support and may benefit users a lot.

After looking over both the RFC and patch I think its a great feature,
and its something I remember Guilherme have bugged about since 5.3's
development stage ;-).

The syntax for one is decent, by having it in the code rather than a
source code comment and its somewhat compatible with that in C#. The
only thing I could see missing in the patch, although its a minor
thing is to dump Annotations when doing something like:
Reflection::export(new Reflection...(...)); and your small TODO in
ReflectionAnnotation::__construct() :)

But I'm a +1 for merging this into trunk, as it will without doubt get
improved as we go, like with Traits.

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net