Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49548
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=sZAC0Ltxsr5LV/Spa9twcAGEtwLWgj8YzSX8Vf1Y+xAVr3dTtnZWHAc5u/hplG+z1G
         fXhS/mmylN02GFfEEGiFgkwVYGa0QBU2UnJRwpae9tKbLW3v/nQeHMPMcN+hvz8rqbk2
         ApIx0tzj9WEbPXNedKm4/SWzA+QwBkGcbKRHo=
MIME-Version: 1.0
Date: Fri, 27 Aug 2010 04:01:46 -0400
Message-ID: <AANLkTin_sqZLJsMhhCMdMY_L0WV_RdYVSOsZHsYmWO-E@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001636426e31b06298048ec9862c
Subject: Bug #47643 - array_diff slowdown
From: lonnyk@gmail.com (Lonny K)

--001636426e31b06298048ec9862c
Content-Type: text/plain; charset=ISO-8859-1

I wanted to discuss this bug to try to get it resolved.  I briefly discussed
this over ICQ and had differing opinions then the person I was talking to,
so naturally I wanted a bigger audience.

Quick summary of what's going on:
* 47643 is about array_diff being slow.
* This was caused by the patch for 42838
* The problem with 42838 is basically that 0 != '0'
* Here is the diff: http://www.lonnylot.com/42838.diff
 The lines that causes the slowdown are:

-				while (*ptrs[i] && (0 < (c = diff_data_compare_func(ptrs[0],
ptrs[i] TSRMLS_CC)))) {
-					ptrs[i]++;
+				while (*ptr && (0 < (c = diff_data_compare_func(ptrs[0], ptr
TSRMLS_CC)))) {
+					ptr++;
 				}


I feel the fix should be reverting 42838 because I feel 42838 wasn't a code
issue, but a documentation issue. It is noted in some places that comparing
a string to an integer results in the string being changed to 0. That is the
issue in 42838 and b/c this is excepted in other places it should be
excepted here. The documentation should be updated to say to typecast your
comparison to (string) if it is going to be important to your code.

--001636426e31b06298048ec9862c--