Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49547 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35201 invoked from network); 27 Aug 2010 03:55:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Aug 2010 03:55:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=adam@adamharvey.name; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=adam@adamharvey.name; sender-id=unknown Received-SPF: error (pb1.pair.com: domain adamharvey.name from 209.85.212.170 cause and error) X-PHP-List-Original-Sender: adam@adamharvey.name X-Host-Fingerprint: 209.85.212.170 mail-px0-f170.google.com Received: from [209.85.212.170] ([209.85.212.170:44043] helo=mail-px0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/02-19815-A47377C4 for ; Thu, 26 Aug 2010 23:55:54 -0400 Received: by pxi17 with SMTP id 17so1208886pxi.29 for ; Thu, 26 Aug 2010 20:55:51 -0700 (PDT) Received: by 10.114.77.11 with SMTP id z11mr12368866waa.112.1282881351211; Thu, 26 Aug 2010 20:55:51 -0700 (PDT) MIME-Version: 1.0 Sender: adam@adamharvey.name Received: by 10.114.159.20 with HTTP; Thu, 26 Aug 2010 20:55:31 -0700 (PDT) In-Reply-To: References: Date: Fri, 27 Aug 2010 11:55:31 +0800 X-Google-Sender-Auth: 6rATCM4hlAzjxKsUSfkgTvFAeg0 Message-ID: To: Joel Perras Cc: RQuadling@googlemail.com, internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Unintuitive array_combine() behaviour From: aharvey@php.net (Adam Harvey) On 27 August 2010 01:07, Joel Perras wrote: > If someone with the appropriate karma could review this and commit it > to trunk, that would be grand. Thanks heaps for the patch, Joel. Looked good to me, and IMO the changed behaviour does make more sense, so I've committed it to trunk. Thanks again, Adam