Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49519
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 87.230.78.165 cause and error)
To: Pierrick Charron <pierrick@webstart.fr>
Cc: internals@lists.php.net
In-Reply-To: <AANLkTimM0t9q0AotdJ3VEx-SbGF0sR_zKTL8PZDM=SmT@mail.gmail.com>
References: <AANLkTimgQZvKX9CVFbux5ZLvusTF9KsWbnU7iVYBYGd8@mail.gmail.com>
	 <bdfb71e696e952a316b1d9c555a5b99e@beberlei.de>
	 <AANLkTimM0t9q0AotdJ3VEx-SbGF0sR_zKTL8PZDM=SmT@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 25 Aug 2010 18:30:48 +0200
Message-ID: <1282753848.3491.25.camel@benny-pc>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Annotation RFC + Patch
From: kontakt@beberlei.de (Benjamin Eberlei)

The inheritance support of annotations only affects classes am I right?
I would get rid of this stuff completely, its rather complicated and
simplify to only returning only the annotations specified on the
reflected class.

As I said before, no-one hinders you from implementing arbitrary complex
user-land annotation frameworks on top of a very simple annotations
implementation that returns simple arrays only.

For inheritance like features the user could walk the inheritance graph
from the specified child to its last super-class and array_merge() all
the annotations it needs.

greetings,
Benjamin

On Wed, 2010-08-25 at 11:59 -0400, Pierrick Charron wrote: 
> One of the advantage of classes vs array is that you have to create
> the class and define its structure and behaviour before using it.
> For example you cannot do with Array something like the [Inherited] annotation :
> 
> [Inherited]
> class SampleAnnotation extends ReflectionAnnotation {}
> 
> How could you define that the SampleAnnotation annotation is Inherited
> or not if you define it on the fly ?
> 
> Pierrick
> 
> 2010/8/25 Benjamin Eberlei <kontakt@beberlei.de>:
> >
> > Hi Pierrick,
> >
> > Awesome RFC! :) I think this is a really useful addition on many levels.
> >
> > We had a chat about this yesterday, i just wanted to throw it into the
> > discussion here again:
> >
> > I think a solution where "->getAnnotations()" returns only an array of the
> > annotations data is simpler to use.
> > Validation of the data would have to be done by the user in this case, but
> > you could of course
> > add a layer in PHP that transforms this data into an object structure.
> >
> > greetings,
> > Benjamin
> >
> > On Wed, 25 Aug 2010 08:56:53 -0400, Pierrick Charron
> > <pierrick@webstart.fr>
> > wrote:
> >> Hello PHP Internals!
> >>
> >> Recently a RFC was included on the PHP Wiki[1].
> >> I know there've been a lot of buzz related to PHP 5.4, but this is not
> >> the subject of this email.
> >>
> >> I'm here to propose a new feature in PHP: Annotations.
> >> A patch is already available with 54 tests for the moment[2].
> >>
> >> I worked together with Guilherme Blanco to make this support happen in
> >> a fresh PHP SVN trunk checkout.
> >> Please review, comment and provide feedback! I think it's a very
> >> useful support and may benefit users a lot.
> >>
> >> [1] http://wiki.php.net/rfc/annotations
> >> [2] http://www.adoy.net/php/Annotations.diff
> >>
> >> Regards,
> >> Pierrick
> >>
> >> (Sorry if you receive this message twice but it looks like I have
> >> problems with the ML)
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>