Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49489
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=cSv87DRGAyCVEt0OIXcTpGqxc2kbxj/jm+BFktpXztmM2iIA+g5V0Ef2B7SDrLFdhR
         MSF7t8y3tb8LRZKbcgUv9VKmm4X2kxLOmSxaOv7sii10nHsgEyTzgq00HR5onik3eFb7
         SUpGGSXSVVCYPSEdU5fpJyXPt3GGK13YEs660=
MIME-Version: 1.0
In-Reply-To: <AANLkTikP0cooG91ZgSeRS+H0fXCjDdLRUpO53OhT8FYC@mail.gmail.com>
References: <AANLkTikP0cooG91ZgSeRS+H0fXCjDdLRUpO53OhT8FYC@mail.gmail.com>
Date: Tue, 24 Aug 2010 15:46:20 +0200
Message-ID: <AANLkTin0RnXPoDms1PhfHwgPbDO09cf_KAnBELAaBipv@mail.gmail.com>
To: Adam Harvey <aharvey@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants
From: pierre.php@gmail.com (Pierre Joye)

hi,

On Tue, Aug 24, 2010 at 12:49 PM, Adam Harvey <aharvey@php.net> wrote:

> http://bugs.php.net/52563 suggests adding an E_NONE constant (set to 0) to
> go with the various other E_* constants we have. I've hacked up a quick
> patch against trunk (attached to the report) that would add that, but don't
> have Zend karma to add it, so I'll open it up to the floor: (a) should we
> have it, and (b) if so, can someone please commit it?
>
> Johannes has pointed out on IRC that E_NONE does already exist in some
> projects, so that's an argument against it.

I don't see it as an argument against as the fix is rather easy:

if (!defined('E_NONE')) {
...

But it should not be added in a minor release.

> Kalle also suggested another constant within that request to provide a
> symbolic version of error_reporting = -1, so there's a second patch in that
> report to add an E_EVERYTHING constant which acts as E_ALL once did: it
> turns on all error reporting.
>
> I'm not terribly attached to either the names or, indeed, the request in
> general, but it'd be nice to get this one closed one way or t'other.

I would like something like E_DEVELOPMENT (notices, warnings,
deprecated and the classic fatal), to strongly advice developers to
use it. On the same line, we could add E_PRODUCTION to set the error
reporting we recommend in production (fatal and warning).

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org