Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49206
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
Content-Type: multipart/mixed; boundary=----------czunXZlclj3M0jK4CsYbKw
To: internals@lists.php.net
References: <op.vgvjivdkidpuyk@cataphract-old.dulce.lo.geleia.net>
Date: Thu, 05 Aug 2010 14:54:21 +0100
MIME-Version: 1.0
Organization: =?iso-8859-15?Q?N=FAcleo_de_Eng=2E_Biom=E9dica_?=
 =?iso-8859-15?Q?do_IST?=
Message-ID: <op.vgywwvyvidpuyk@cataphract-old.dulce.lo.geleia.net>
In-Reply-To: <op.vgvjivdkidpuyk@cataphract-old.dulce.lo.geleia.net>
User-Agent: Opera Mail/10.60 (Win32)
Subject: Re: [PHP-DEV] (now with PATCH) Closures, rebinding and scopes 
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

------------czunXZlclj3M0jK4CsYbKw
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit

Hi

I've modified Closure::bindTo/Closure::bindTo so that they accept another  
argument that defines the new scope. This can either be an object (its  
class is used as the scope) or a class name.

I changed the current behavior so that:

* If the scope is not given, the current one is kept. This permits  
changing the bound instance without changing the calling scope. The  
current behavior (set the scope to the class of the new bound instance)  
makes useless rebinding of closures that were defined up in the class  
hierarchy.
* I also changed the order of the arguments of Closure::bindTo so that I  
could unify Closure::bind and Closure::bindTo under a single  
implementation which plays nice with zend_parse_method.

Additionally, I added the method Closure::getScope, which returns the  
currently set calling scope of the closure.

Finally, I added four tests. Tests closure_038 and closure_039 fail. Both  
present memory corruption and, in addition to that, closure_039 also gives  
incorrect results because the rebounding confuses the cache. Note that  
these problems were already present (they weren't caused by the changes,  
as far as I know). I attached the logs.

-- 
Gustavo Lopes
------------czunXZlclj3M0jK4CsYbKw--