Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:49169
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=LzBo0lqCooJ3IWQU4za26jXgDGpAvQIVlUYeKXFpYk0puuyW9FtT+LfxmvghQeBvvf
         yWj+8Da0iE4XZNG26JNFl6eBaYE50RvS2tLdFnHsxiwidxwwoGOcAj6CLm/Sbqyi+u/i
         XLBIai2RnT1SkOucohFn+aXo17A+AePoGmjEo=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=C_LS5jnJ1ST7XUv6CMpBNEJFzrigcOQGXFqhq@mail.gmail.com>
References: <AANLkTimDdM4Udx53qW8jU4NuP3kU8+vmU6y4ZgXRVn+X@mail.gmail.com>
	<AANLkTim+SW7wM9U+eYTpyHWrg08_r49TABSxpoa_qVCm@mail.gmail.com>
	<AANLkTi=eyqftrdnbVt+w2q9nrS=+DxNsRB8cL4Kf5+1n@mail.gmail.com>
	<AANLkTi=C_LS5jnJ1ST7XUv6CMpBNEJFzrigcOQGXFqhq@mail.gmail.com>
Date: Thu, 29 Jul 2010 08:57:12 -0300
Message-ID: <AANLkTi=GHSHTvdVZyLDLaoSY7Be=tCkuA=5ppb-fe=rz@mail.gmail.com>
To: Ferenc Kovacs <info@tyrael.hu>, Ilia Alshanetsky <ilia@prohost.org>
Cc: Daniel Egeberg <daniel.egeberg@gmail.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001636eefc8a4c3dac048c856f24
Subject: Re: [PHP-DEV] [RFC] Return type-hint
From: felipensp@gmail.com (Felipe Pena)

--001636eefc8a4c3dac048c856f24
Content-Type: text/plain; charset=UTF-8

Hi

2010/7/29 Ferenc Kovacs <info@tyrael.hu>

> >> Hi, I would love this feature.
> >> But I have some concerns.
> >> AFAIK you can declare classes with the name int ,scalar, etc. so
> >> hinting anything else than class names can be ambiguous.
> >> Or we have to set these keywords as reserved, so nobody could declare
> >> classes with such names.
> >
> > Weren't they already made reserved with the parameter type hinting patch?
> >
>
> As I said:
>
> > Maybe this was resolved with the last scalar type hinting patch, which
> > got merged to the trunk, I don't know.
>

Currently on trunk version, if you use the php native types as type-hint it
will check for the php type, not the user class.

Trunk:
<?php

class int { }

function test(int $a) { }

test(1); // ok
test(new int); // error

Which is just like the return type-hint is working. I do prefer offer a way
to continue using the user class 'Int', as we not going to add new
keywords... My suggestion (I guess already told it in some mail...) is to
identify the native php type just when it's lowercased (case-sensitive).
(Java-style)

Patch: http://felipe.ath.cx/diff/param-typehint-native-type.diff

Example:
<?php

class int { }

function test(Int $a) { } // user class 'Int'
function test2(int $a) { } // native type 'int'

test(new int); // ok
test2(1); // ok



Thanks for the feedbacks. :-)

-- 
Regards,
Felipe Pena

--001636eefc8a4c3dac048c856f24--