Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:49103 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55928 invoked from network); 20 Jul 2010 21:15:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jul 2010 21:15:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 217.114.211.66 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 217.114.211.66 unknown Solaris 10 (beta) Received: from [217.114.211.66] ([217.114.211.66:49170] helo=config.schlueters.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 15/00-55737-ED1164C4 for ; Tue, 20 Jul 2010 17:15:21 -0400 Received: from [192.168.1.28] (ppp-93-104-103-33.dynamic.mnet-online.de [93.104.103.33]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by config.schlueters.de (Postfix) with ESMTPSA id B7EDE441DF; Tue, 20 Jul 2010 23:15:07 +0200 (CEST) To: Pierre Joye Cc: "Jonah H. Harris" , PHP Developers Mailing List In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 20 Jul 2010 23:14:40 +0200 Message-ID: <1279660480.2339.35.camel@samnmax> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH]: Fix for PDOStatement::debugDumpParams() From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Tue, 2010-07-20 at 23:02 +0200, Pierre Joye wrote: > hi, > > Can you open a bug and attach the patch to it please? and please add the bug in "unified diff" format (diff -u) which makes it simpler to read. Thanks! johannes > Thanks for your work, > > On Tue, Jul 20, 2010 at 10:30 PM, Jonah H. Harris > wrote: > > Per the documentation > > (http://php.net/manual/en/pdostatement.debugdumpparams.php), > > PDOStatement::debugDumpParams should be emitting the bind parameter value. > > Currently however, it does not. Accordingly, attached is a patch for 5.2 > > (which also applies cleanly to 5.3), which emits the bind parameter value. > > > > While there are quite a few different ways to print and/or get a printable > > version of the zval without having to convert the parameter to a string > > in-place, I felt that zend_make_printable_zval was the most appropriate. > > Feel free to correct me though ;-) > > > > Also, the first example in the documentation is incorrect, as bindValue can > > take at most three arguments. > > > > In the example: > > > > $sth->bindValue(':colour', $colour, PDO::PARAM_STR, 12); > > > > should be: > > > > $sth->bindValue(':colour', $colour, PDO::PARAM_STR); > > > > > > -- > > Jonah H. Harris, VP of Database Administration > > myYearbook.com > > > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >