Newsgroups: php.cvs,php.internals,php.pdo Path: news.php.net Xref: news.php.net php.cvs:62891 php.internals:48784 php.pdo:457 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18696 invoked from network); 15 Jun 2010 11:11:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jun 2010 11:11:25 -0000 Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.212.42 cause and error) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.212.42 mail-vw0-f42.google.com Received: from [209.85.212.42] ([209.85.212.42:43728] helo=mail-vw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2F/3F-31991-CDF571C4 for ; Tue, 15 Jun 2010 07:11:25 -0400 Received: by vws2 with SMTP id 2so1930052vws.29 for ; Tue, 15 Jun 2010 04:11:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.51.225 with SMTP id e33mr2956037qag.316.1276600281760; Tue, 15 Jun 2010 04:11:21 -0700 (PDT) Received: by 10.220.70.202 with HTTP; Tue, 15 Jun 2010 04:11:21 -0700 (PDT) Date: Tue, 15 Jun 2010 07:11:21 -0400 Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: Ilia Alshanetsky , php-cvs@lists.php.net, PHP internals list , pdo Content-Type: multipart/alternative; boundary=00c09fa2176f50851a04890faa34 Subject: Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_dbh.c branches/PHP_5_3/ext/pdo/php_pdo_driver.h branches/PHP_5_3/ext/pdo_pgsql/pdo_pgsql.c branches/PHP_5_3/ext/pdo_pgsql/pgsql_driver.c branches/PHP_5_3/ext/pdo_pgsq From: ilia@prohost.org (Ilia Alshanetsky) --00c09fa2176f50851a04890faa34 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I'll adjust the code to simply use in_txn flag for the moment to avoid the structure change. 2010/6/14 Johannes Schl=FCter > On Thu, 2010-06-10 at 12:11 +0000, Ilia Alshanetsky wrote: > > Modified: php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- > > php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h 2010-06-10 > > 11:45:51 UTC (rev 300350) > > +++ > > php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h 2010-06-10 > > 12:11:19 UTC (rev 300351) > > @@ -310,6 +310,7 @@ > > pdo_dbh_check_liveness_func check_liveness; > > pdo_dbh_get_driver_methods_func get_driver_methods; > > pdo_dbh_request_shutdown persistent_shutdown; > > + pdo_dbh_txn_func in_transaction; > > }; > > > > /* }}} */ > > Here you are changing a structure which is allocated and initialized in > a driver and then read from the PDO core. PDO core will therefore read > invalid memory when a driver compiled against 5.3.2 is used in 5.3.3 > while we usually guarantee binary compatibility in bug fix releases. > > This for instance affects distributors or MSFT's sqlsrv driver. > > johannes > > > > --00c09fa2176f50851a04890faa34--