Newsgroups: php.cvs,php.internals,php.pdo Path: news.php.net Xref: news.php.net php.cvs:62881 php.internals:48778 php.pdo:453 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52695 invoked from network); 14 Jun 2010 16:01:20 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Jun 2010 16:01:20 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 74.125.82.42 mail-ww0-f42.google.com Received: from [74.125.82.42] ([74.125.82.42:42560] helo=mail-ww0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F1/2F-07295-A42561C4 for ; Mon, 14 Jun 2010 12:01:15 -0400 Received: by wwe15 with SMTP id 15so1015407wwe.29 for ; Mon, 14 Jun 2010 09:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:cc:content-type; bh=9aoJ7HF/7ZDYqrpUks0Kef0qAzJjRPuZZjhdqeeK0cw=; b=uPOXPe+Db10ofJZmTsTtw/z+42aQVtYnMV4Xnz5O/95VqCHUoTrdcJe8gOdMABM3rP ckOOQeYqAsalSjlHEYm6ixMWaCQjBszLc6Q1IMkYwb0T0a77HTWSBDMaiCCpL/kD9M6d HHSua70c49Z/ZdordBWKZlKBqC7hLcqT82Rao= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=UGvMSjcMeLtxR9wah65+/hkJQkexQ1t2x2ODlgfxEllLrBQQ60EYPQHrLMqszu5xfR IveAkPdhL4/mPXYg04f6ZmA58QurAD+sPzcVpikuv5sIVsybfYgeLsKZhPB/27fPs4lW aeHmpPWL2yhv9uIdlJLvH7KzMZlFvyE2cdLi8= MIME-Version: 1.0 Received: by 10.227.137.1 with SMTP id u1mr5858537wbt.68.1276531270528; Mon, 14 Jun 2010 09:01:10 -0700 (PDT) Received: by 10.216.169.79 with HTTP; Mon, 14 Jun 2010 09:01:10 -0700 (PDT) Date: Mon, 14 Jun 2010 18:01:10 +0200 Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: Ilia Alshanetsky , php-cvs@lists.php.net, PHP internals list , pdo Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_dbh.c branches/PHP_5_3/ext/pdo/php_pdo_driver.h branches/PHP_5_3/ext/pdo_pgsql/pdo_pgsql.c branches/PHP_5_3/ext/pdo_pgsql/pgsql_driver.c branches/PHP_5_ From: pierre.php@gmail.com (Pierre Joye) > Here you are changing a structure which is allocated and initialized in > a driver and then read from the PDO core. PDO core will therefore read > invalid memory when a driver compiled against 5.3.2 is used in 5.3.3 > while we usually guarantee binary compatibility in bug fix releases. > > This for instance affects distributors or MSFT's sqlsrv driver. Not only that, but why in the world did you commit that to 5.3? 5.3 is bug fix only, committing something like in trunk is bad enough, but adding that in 5.3 is simply not correct. Please revert. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org