Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48756
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=YufCQ448+7lkUlp2wSnBWbM+cZkYPveAOwqOqjUYpTabknelIQ2861WJ0wmupNRJKZ
         yIiNQQ2tiGgP4tFdifgQRFyNzHJ49IhDhgdtAXd0KJ1hBrt6PyTMueNueuc5h3oDjwMS
         fzYlbY5H6XTm6jmj/Vfxe9cPTEqOtgds4PKcs=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <4C14BE21.2040401@quis.cx>
References: <4C14BE21.2040401@quis.cx>
Date: Sun, 13 Jun 2010 15:05:12 +0200
Message-ID: <AANLkTil137QTc-Uyn58PRH7-JW6oA5WLqQao_uq_Vf-c@mail.gmail.com>
To: Jille Timmermans <jille@quis.cx>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] #45351: Exception::getTrace() should return 'object' 
	array-element
From: kalle@php.net (Kalle Sommer Nielsen)

Hello Jille

2010/6/13 Jille Timmermans <jille@quis.cx>:
> http://bugs.php.net/45351
>
> I have attached a patch to the feature request. IIRC I should just ask
> here whether someone is willing to commit it. So, anyone willing to help
> me? :)

The patch is incorrect (according to what the user requests, and for
consistency with debug_backtrace()). What the patch should do is to:

1) Add a new parameter to the arginfo, so reflection can pick this new
parameter up, named provide_object
2) Alter the implementation of Exception::getTrace(),
::getTraceAsString() and possibly also ::__toString() so it sends to
the proper parameters to the function that builds the trace
array/string

If you simply change the 0 to 1, then it will be forced every time,
and without looking closer to the implementation i can imagine it
could cause some unwanted overheat if its not used, or lookup time.

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net