Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:48678 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99846 invoked from network); 8 Jun 2010 00:14:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jun 2010 00:14:27 -0000 Authentication-Results: pb1.pair.com header.from=felipensp@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=felipensp@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: felipensp@gmail.com X-Host-Fingerprint: 209.85.161.42 mail-fx0-f42.google.com Received: from [209.85.161.42] ([209.85.161.42:44783] helo=mail-fx0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A7/C5-22982-26B8D0C4 for ; Mon, 07 Jun 2010 20:14:27 -0400 Received: by fxm5 with SMTP id 5so380075fxm.29 for ; Mon, 07 Jun 2010 17:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=Jn1CNaLlwVDlK/vl5Nn97eAY5kWiEjyFeIbb+60cWfU=; b=DwaBUOrmvC1TtjNGNEv9tPqc8mdQQPF9lHteOBYft3WcS3CqyXnduH0MlcOKVDpi79 6ngfVNpxWvbhF2PA84MSV0GKC2vq2ZrMwuRvMjzMmnyZ/3DH6TFPG/wN48Pb6Ppxt67k uItkpArBdqgm6Eb9WsPGUCu2St0aUra8ZY/3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=qCRWB5jKAtXzoFkHSWDeVIi0C4qUiNZPmtr5YHYl8XrnfZDLFZjgJobmTM4FlOBg0v T1uHHGD3FZvBoLgqhuFiXsjthv9yWJQ9lmZhbhNWNMdkcnVXSxdk4ZE+1CyC2Vfs2VL4 Ma8ck/5qxAa8Nw/kMbHHTjG45ENK9jo2iyzR4= MIME-Version: 1.0 Received: by 10.103.86.32 with SMTP id o32mr5223275mul.99.1275956063779; Mon, 07 Jun 2010 17:14:23 -0700 (PDT) Received: by 10.103.160.17 with HTTP; Mon, 7 Jun 2010 17:14:23 -0700 (PDT) In-Reply-To: <4C0D59DE.50106@sugarcrm.com> References: <4C0D2DBE.9040305@sugarcrm.com> <4C0D59DE.50106@sugarcrm.com> Date: Mon, 7 Jun 2010 21:14:23 -0300 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=0016e65aeea2ee3b9d048879ab74 Subject: Re: [PHP-DEV] [RFC] Array Dereferencing From: felipensp@gmail.com (Felipe Pena) --0016e65aeea2ee3b9d048879ab74 Content-Type: text/plain; charset=UTF-8 2010/6/7 Stas Malyshev > Hi! > > > This is great. Did you check it on debug version though? I thought for >> some reason you'd have to take care of freeing the value (which is >> returned by function) after the expression is done, but maybe I missed >> something. It's be also nice to see some more assignment tests (also >> maybe return-array-by-ref test). >> > > I checked it with debug and every case I could think of and it seems to be > working just fine, so - commit it to trunk :) > > Yes, I always use ZTS+Debug build :P I have committed the patch and added new tests. Thanks guys for the feedback. -- Regards, Felipe Pena --0016e65aeea2ee3b9d048879ab74--