Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:4862 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10671 invoked by uid 1010); 16 Oct 2003 09:17:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 10647 invoked from network); 16 Oct 2003 09:17:06 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 16 Oct 2003 09:17:06 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9G9H6M03216 for ; Thu, 16 Oct 2003 05:17:06 -0400 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9G9H6r31656 for ; Thu, 16 Oct 2003 05:17:06 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by lacrosse.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9G9H5t08044 for ; Thu, 16 Oct 2003 05:17:05 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id h9G9H4SV009655 for ; Thu, 16 Oct 2003 10:17:04 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id h9G9H41I009654 for internals@lists.php.net; Thu, 16 Oct 2003 10:17:04 +0100 Date: Thu, 16 Oct 2003 10:17:04 +0100 To: internals@lists.php.net Message-ID: <20031016091704.GA16511@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] disallow --enable-versioning with shared modules From: jorton@redhat.com (Joe Orton) --enable-versioning requests that the linker just exports certain entries in the dynamic symbol table; this is not compatible with the use of shared modules, which requires that the SAPI exports all its symbols, zend_* and so on, otherwise modules can't use them. This combination will not have worked for ages on platforms such as Solaris and AIX, where libtool 1.4 implements -export-symbols correctly; also on Linux with libtool 1.5 (where before, -export-symbols was in effect a noop). Index: configure.in =================================================================== RCS file: /repository/php-src/configure.in,v retrieving revision 1.396.2.80 diff -u -r1.396.2.80 configure.in --- configure.in 7 Oct 2003 10:04:51 -0000 1.396.2.80 +++ configure.in 16 Oct 2003 09:00:11 -0000 @@ -765,6 +765,9 @@ dnl ------------------------------------------------------------------------- if test "$PHP_VERSIONING" = "yes"; then + if test -n "$PHP_MODULES"; then + AC_MSG_ERROR([--enable-versioning cannot be used with shared modules]) + fi test -z "$PHP_SYM_FILE" && PHP_SYM_FILE="$abs_srcdir/sapi/$PHP_SAPI/php.sym" if test -f "$PHP_SYM_FILE"; then EXTRA_LDFLAGS="-export-symbols $PHP_SYM_FILE $EXTRA_LDFLAGS"