Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=NKQ6FQfZWIoCtY6E7R/godBgkFl7zm8NjdkwnZwKrgOxdW0rnxVCfhseH62etqODC1
         m3bvlMzpD/vQJ4bkjbHVaI4opR/iJfKCKOgJvZUB/2UX5WjyIWexlHgkweQljJy7JTgJ
         XiyoobSeXaPSDBSWkUsplywzcBKoGk6jDhm7Q=
MIME-Version: 1.0
In-Reply-To: <7A.44.45208.19295FB4@pb1.pair.com>
References: <7A.44.45208.19295FB4@pb1.pair.com>
Date: Thu, 20 May 2010 21:58:52 +0200
Message-ID: <AANLkTilOsavbKrJVlNGfnppZUKhUJwsOGjb5T0MgDP7a@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] json_decode() and integers larger than LONG_MAX (2^31 - 
	1)
From: pierre.php@gmail.com (Pierre Joye)

hi Sara,

The idea sounds sane, until we have big integer support :)

Only one thing, I would suggest to use JSON_BIGINT_AS_STRING instead,
more clear about its effect.

Cheers,

On Thu, May 20, 2010 at 9:50 PM, Sara Golemon <pollita@php.net> wrote:
> I know this issue has been seen before, but I hope to do something about =
it.
>
> $json =3D '1234567890123456789';
> $x =3D json_decode($json);
> /* $x is now a float *aproximately*
> =A0* equal to the original value
> =A0*/
>
> For database indexes, being off by one can be disasterous for application
> flow, so I'd like to include the option to decode very large integers as
> strings.
>
> To that end, I propose a change in json_decode()'s signature to add an
> optional fourth argument, mirroring json_encode()'s second argument:
>
> mixed json_decode(string $json[, bool $assoc =3D false[, int $depth =3D 5=
12[,
> int $options]]]);
>
> Where $options is a bitmask of zero or more of the following:
>
> JSON_BIGINT_STRING - Store large integers as their original string value
>
> With the corresponding simple changes in json.c and JSON_parser.c
>
> If noone objects or offers comments, I'll implement this.
>
> -Sara
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org