Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48307
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=mlvpAYCGP1ItGGY4JogE71f9XHoxgl/Icn8jQJqggVU/hgln6c10JbAX6b303fJTlT
         BoHbSSLLwVEEDgZKtzU6xZ+Odrpf15IalrETYwqhzQSbEK5qeOU0VpG0mnwhJUow7hje
         fDKnPVZu/kd6eMZxVyrwg2d5rgX7eBL8QXfUw=
MIME-Version: 1.0
In-Reply-To: <D0.2B.05421.113F1FB4@pb1.pair.com>
References: <D0.2B.05421.113F1FB4@pb1.pair.com>
Date: Tue, 18 May 2010 08:41:52 +0200
Message-ID: <AANLkTilSOPh0yWZ6dcXCK-v7fcQDeRUcV85M6aOeD4in@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] openssl_(en|de)crypt missing IV
From: pierre.php@gmail.com (Pierre Joye)

hi Sara,

On Tue, May 18, 2010 at 3:53 AM, Sara Golemon <pollita@php.net> wrote:
> I was just looking through the implementation of openssl_encrypt() (and
> openssl_decrypt()) today because I need to make some encrypted payloads, =
but
> the prototype didn't have anywhere to place an initialization vector.
>
> On opening ext/openssl/openssl.c, I noticed line 4620 which simply hardco=
des
> IV as a string of NULL bytes.
>
> This is a bad idea roughly equivalent to hashing passwords without salt;
> Worse, it prevents interoperability at the application layer by preventin=
g
> the decryption of a data stream where the generator used an IV other than
> all-null.
>
> Fixing this is a simple matter, but I wanted to bounce approaches for BC =
(or
> lack thereof) off everyone else since this version of openssl_encrypt() i=
s
> already "in the wild".

> I think it's worth a BC break. =A0Comments?

To break BC is a no go, even if your arguments are appealing (even in
a major version).

I would suggest a new function:

openssl_encrypt_iv($data, $method, $key, $iv, $raw=3Dfalse);

Which will use the same internal implementations internally but with a
different entry point. please note that I moved iv to the 4th position
as well.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org